Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Developer name is listed instead of app name in "flatpak list" #5700

Closed
4 tasks done
kparal opened this issue Feb 21, 2024 · 6 comments · Fixed by #5701
Closed
4 tasks done

[Bug]: Developer name is listed instead of app name in "flatpak list" #5700

kparal opened this issue Feb 21, 2024 · 6 comments · Fixed by #5701
Labels

Comments

@kparal
Copy link

kparal commented Feb 21, 2024

Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.
  • If this is an issue with a particular app, I have tried filing it in the appropriate issue tracker for the app (e.g. under https://github.com/flathub/) and determined that it is an issue with Flatpak itself.
  • This issue is not a report of a security vulnerability (see here if you need to report a security issue).

Flatpak version

1.15.6

What Linux distribution are you using?

Fedora Linux

Linux distribution version

39

What architecture are you using?

x86_64

How to reproduce

  1. Run flatpak list --app
  2. Look at the Name column
  3. Apps which have <developer><name>FOO</name></developer> tag (documentation) in their manifest display FOO as the app name, instead of the actual app name

Expected Behavior

App name should be displayed correctly in flatpak list

Actual Behavior

Developer name is displayed instead of the app name.

Additional Information

Here's a trimmed example of selected apps installed from Flathub:

$ flatpak list --app
Name                    Application ID                      Version           Branch    Origin         Installation
Janne Pulkkinen         com.github.Matoking.protontricks    1.11.1            stable    flathub        system
Xournalpp Developers    com.github.xournalpp.xournalpp      1.2.2             stable    flathub        system
Bottles Contributors    com.usebottles.bottles              51.11             stable    flathub        system
Zenju                   org.freefilesync.FreeFileSync       13.4              beta      flathub-beta   system

As you can see, the Name column displays the developer name instead of the app name.

@chrisawi
Copy link
Collaborator

The incorrect name is getting into the deploy data. It looks like the parser in flatpak takes any <name> element, so the new <developer><name> syntax is confusing it.

https://github.com/flatpak/flatpak/blob/main/common/flatpak-appdata.c#L122

chrisawi added a commit to chrisawi/flatpak that referenced this issue Feb 21, 2024
<developer_name> has been deprecated in favor of <developer> with a
<name> child. We need to ensure that this developer name isn't parsed
as the application name.

Fixes: flatpak#5700
@geraldosimiao
Copy link

yeah, I'm seeing this too, even on the info output:

flatpak info org.telegram.desktop

John Preston - Fast. Secure. Powerful.

        ID: org.telegram.desktop
       Ref: app/org.telegram.desktop/x86_64/stable
      Arq.: x86_64
      Ramo: stable
    Versão: 4.15
   Licença: GPL-3.0
    Origem: flathub
   Coleção: org.flathub.Stable
Instalação: system
 Instalado: 213,7 MB
   Runtime: org.freedesktop.Platform/x86_64/23.08
       Sdk: org.freedesktop.Sdk/x86_64/23.08

    Commit: b280758ce502a3386033f001ec5f97fcca7a661b0ca7aba7772541bcd9e1e182
       Pai: 8a2eb06ae31255b4882bb7fae73b958cc384cf72f55d11619d6656af8ebb236f
   Assunto: Update libjxl-0.9.2.tar.gz to 0.10.0 (dd43793f)
      Data: 2024-02-22 04:52:52 +0000

TingPing pushed a commit that referenced this issue Mar 12, 2024
<developer_name> has been deprecated in favor of <developer> with a
<name> child. We need to ensure that this developer name isn't parsed
as the application name.

Fixes: #5700
TingPing pushed a commit that referenced this issue Mar 12, 2024
<developer_name> has been deprecated in favor of <developer> with a
<name> child. We need to ensure that this developer name isn't parsed
as the application name.

Fixes: #5700
wjt added a commit to endless-network/Aqueducts_Binary that referenced this issue Mar 29, 2024
I'm placing this above the <name> tag in the hope of working around
flatpak/flatpak#5700 Flatpak bug where the
developer name is taken to be the name of the application.
wjt added a commit to endless-network/Aqueducts_Binary that referenced this issue Mar 29, 2024
I'm placing this above the <name> tag in the hope of working around
flatpak/flatpak#5700 Flatpak bug where the
developer name is taken to be the name of the application.
@bbhtt
Copy link
Contributor

bbhtt commented Apr 25, 2024

Am I missing something because this doesn't seem fixed in 1.15.7+ ?

image

@chrisawi
Copy link
Collaborator

chrisawi commented Apr 25, 2024

Am I missing something because this doesn't seem fixed in 1.15.7+ ?

It will persist until each app is updated or reinstalled because the incorrect name was stored in the deploy data.

I've just reconfirmed that it's fixed in F40 with 1.15.8.

@bbhtt
Copy link
Contributor

bbhtt commented Apr 25, 2024

Yea that was it thanks. I didn't notice it was being stored in the deploy file separately.

GeorgesStavracas pushed a commit to GeorgesStavracas/flatpak that referenced this issue Apr 26, 2024
<developer_name> has been deprecated in favor of <developer> with a
<name> child. We need to ensure that this developer name isn't parsed
as the application name.

Fixes: flatpak#5700
@boredsquirrel
Copy link

boredsquirrel commented May 7, 2024

hi, thanks for taking care of it! Is there no way to force reload the metadata?

the brute force method in bash would be

list=$(flatpak list --app --columns=application)

for app in $list
	do
		flatpak install --user --reinstall -y "$app"
done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants