Test suite fails with no useful errors if socat is missing #5020
Comments
GeorgesStavracas
added a commit
to GeorgesStavracas/flatpak
that referenced
this issue
Oct 3, 2023
The tests/make-test-runtime.sh scripts sets '-e' in lieu of implementing useful error checking, but doesn't actually check if the programs it uses exist in the first place; and aborts silently when they're not available. It is more useful to warn about them, and stop execution earlier. This leaves some leftover files, but arguably that's better than leaving leftover files AND people scratching their heads. Warn about missing required programs. Related: flatpak#5020
smcv
pushed a commit
that referenced
this issue
Oct 4, 2023
The tests/make-test-runtime.sh scripts sets '-e' in lieu of implementing useful error checking, but doesn't actually check if the programs it uses exist in the first place; and aborts silently when they're not available. It is more useful to warn about them, and stop execution earlier. This leaves some leftover files, but arguably that's better than leaving leftover files AND people scratching their heads. Warn about missing required programs. Related: #5020
|
Assuming #5548 is sufficient for now |
smcv
pushed a commit
to smcv/flatpak
that referenced
this issue
Nov 14, 2023
The tests/make-test-runtime.sh scripts sets '-e' in lieu of implementing useful error checking, but doesn't actually check if the programs it uses exist in the first place; and aborts silently when they're not available. It is more useful to warn about them, and stop execution earlier. This leaves some leftover files, but arguably that's better than leaving leftover files AND people scratching their heads. Warn about missing required programs. Related: flatpak#5020 (cherry picked from commit 6a57fa4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tests/make-test-runtime.shsets-ein lieu of implementing useful error checking, and will simply abort silently, with no error messages, ifsocatisn't installed on the system. The build system doesn't check for it,The text was updated successfully, but these errors were encountered: