-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exported D-Bus services not seen on installation #3145
Comments
I think we should just create the symlink with some temp name and move it into place. Should make it get the right event. |
alexlarsson
added a commit
to alexlarsson/flatpak
that referenced
this issue
Oct 2, 2019
Rather than unlinking and symlinking the new value we symling into a temporary name and then atomically renames on top of the (possibly) pre-existing file. This has two advantages. First it is atomic, whereas the previous code could end up removing the old code without creating the new one, and secondly this will generate a move inotify event which is what dbus-broker uses to detect changes in the services file directory. Fixes flatpak#3145
I believe that PR should fix this, as it gives:
When installing gedit. |
alexlarsson
added a commit
that referenced
this issue
Oct 2, 2019
Rather than unlinking and symlinking the new value we symling into a temporary name and then atomically renames on top of the (possibly) pre-existing file. This has two advantages. First it is atomic, whereas the previous code could end up removing the old code without creating the new one, and secondly this will generate a move inotify event which is what dbus-broker uses to detect changes in the services file directory. Fixes #3145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Testing with F30, dbus-broker:
The problem here is that dbus-broker (and also dbus-daemon as far as I can tell from reading the code) watch service directories with:
Which does not notice new symlinks in a directory, since that's IN_CREATE. I'll file an issue against dbus-broker - whether they'll fix it or not may depend on how serious they are with bug-for-bug compatibility with dbus-daemon. It might make sense to put a workaround in Flatpak in any case.
The text was updated successfully, but these errors were encountered: