XDG_DATA_DIRS is not set on fish shell #3109

qlem · 2019-09-17T19:37:33Z

Linux distribution and version

5.2.14-arch2-1-ARCH - x86_64 GNU/Linux

Flatpak version

Flatpak 1.4.2

Description of the problem

XDG_DATA_DIRS is not set on fish shell. No desktop entry appears after install an app.

Steps to reproduce

Use fish shell as default shell, install flatpak then an app.

TingPing · 2019-09-17T23:09:38Z

I've been using fish for years and Flatpaks dirs have always been picked up.

refi64 · 2019-09-18T03:41:47Z

You need to reboot once when you first install Flatpak, I'm guessing that's the issue given that desktop entries aren't appearing either.

…

On Tue, Sep 17, 2019, 2:37 PM qlem ***@***.***> wrote: Linux distribution and version 5.2.14-arch2-1-ARCH - x86_64 GNU/Linux Flatpak version x86_64 GNU/Linux Description of the problem XDG_DATA_DIRS is not set on fish shell. No desktop entry appears after install an app. Steps to reproduce Use fish shell as default shell, install flatpak then an app. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3109?email_source=notifications&email_token=AAM4YSK5I5YHD34HHMZNNGTQKEWX7A5CNFSM4IXUIYJ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HL6IBVA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAM4YSOWFLUYERG6IAOBOGLQKEWX7ANCNFSM4IXUIYJQ> .

qlem · 2019-09-18T20:22:49Z

You need to reboot once when you first install Flatpak

I just tried, doesn't work. I have reboot after Flatpak install and after app install too. $XDG_DATA_DIRS is still not defined.

$> echo $XDG_DATA_DIRS
/usr/local/share:/usr/share

I have to update $XDG_DATA_DIRS myself.

Poorchop · 2019-12-14T23:59:52Z

I was getting an error about both /var/lib/flatpak/exports/share and /home/me/.local/share/flatpak/exports/share not being in the search path for XDG_DATA_DIRS so I added them both in my fish config. Somehow I still get an error about /home/me/.local/share/flatpak/exports/share still not being in the search path even though echo $XDG_DATA_DIRS returns /var/lib/flatpak/exports/share /home/me/.local/share/flatpak/exports/share /usr/share/xfce:/var/lib/flatpak/exports/share /home/me/.local/share/flatpak/exports/share:/usr/share.

matthiasclasen · 2019-12-15T16:13:58Z

The expected format is :-separated. Your XDG_DATA_DIRS seems to be partially space-separated.

Poorchop · 2019-12-15T17:37:06Z

That's because echo $PATH looks at the value of the variable in fish. I am setting the variable properly as far as I'm aware since fish takes a list of arguments separated by spaces, which it then separates with colons when exporting it.

TingPing · 2019-12-15T23:47:28Z

Hmm, Actually I can reproduce this now... Eitherway this isn't a Flatpak bug, it was working and fish is somehow inheriting the env vars incorrectly.

adaigre · 2020-01-26T23:52:37Z

I've got the same problem on a Fedora 31 Workstation with KDE.
$XDG_DATA_DIRS is not propagated to fish. chsh -s /bin/bash solves the issue.

doums · 2020-04-15T20:19:02Z

I have the same problem using fish as login shell.

MatthiasGrandl · 2020-05-06T17:56:36Z

Uh so anyone got a solution without setting the variable themselves? Don't really want to chsh just because of this annoyance.

corvore · 2020-05-06T19:10:06Z

Uh so anyone got a solution without setting the variable themselves? Don't really want to chsh just because of this annoyance.

I don't use a lot of flatpaks. So I've done some shims in the past. Basically make a file that runs the Flatpak named what you want it named in use/bin with a .desktop pointing to it in menus.

It's dumb but works.

travankor · 2020-05-09T11:29:00Z

Shouldn't someone report this on the fish tracker since it seems like a regression on their side?

matwey · 2020-05-29T11:32:04Z

I would not say that this is an issue in fish.
Isn't there a better way to setup environment variables for a user session than just relying on /etc/profile.d/flatpak.sh (mind .sh suffix)?

Vogtinator · 2020-05-29T11:47:21Z

See also this discussion about /etc/profile and fish in sddm: sddm/sddm#879

It might be possible to add a hack into the session script, which uses /bin/sh to run the profile script and then read back the changed environment. That could cause some surprising behaviour though and might even break stuff further.

travankor · 2020-05-29T21:13:07Z

Does this recently added command in fish help?

Isn't there a better way to setup environment variables for a user session than just relying on /etc/profile.d/flatpak.sh (mind .sh suffix)?

/etc/environment? But you have more limitations than /etc/profile.d, like no variable expansion.

If fish doesn't want to implement POSIX, shouldn't they advertise a way to setup system environment variables? I think if multiple third party projects have run into this issue before, then this indicates a usability issue in fish, at least.

matwey · 2020-05-29T21:21:50Z

They advertise to use /etc/environment:
fish-shell/fish-shell#3665

travankor · 2020-05-31T18:19:40Z

Still think this is an issue with fish in general. /etc/environment and login.defs are OS-specific, do not offer config snippets, and somewhat limited in general since it just reads KEY=VALUE, which is why profile.d is popular. What flatpak could do is have a fish-specific file in /usr/share/fish/vendor_conf.d.

refi64 · 2020-06-04T22:02:55Z

/etc/environment doesn't really let you append to environment variables from what I can tell, thus using it for XDG_DATA_DIRS is a no-go.

…

On Sun, May 31, 2020 at 1:19 PM travankor ***@***.***> wrote: Still think this is an issue with fish in general. /etc/environment and logins.defs are OS-specific and somewhat limited in general, which is why profile.d is popular. What flatpak could do is have a fish-specific function in /usr/share/fish/vendor_conf.d. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3109 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM4YSJMDEA5DEQVVZX2XDDRUKNURANCNFSM4IXUIYJQ> .

-- Ryan (ライアン) Yoko Shimomura, ryo (supercell/EGOIST), Hiroyuki Sawano >> everyone else https://refi64.com/

PureTryOut · 2020-11-09T08:12:26Z

This just happened to me. Flatpak desktop files have been showing up fine till a system update somewhere last week and now they don't anymore. According to the system package manager Flatpak hasn't been upgraded in the meantime so I'm not sure what changed.

soredake · 2020-11-09T10:16:06Z

bass source /etc/profile as workaround

As a temporary workaround for flatpak/flatpak#3109.

sebastianwagner · 2020-11-23T18:06:46Z

It could also to be a bug in debians patches for lxde-common / openbox-lxde-session debian #906288.
A solution could be https://bugs.launchpad.net/debian/+source/lxde-common/+bug/1905289

Also check raspians solution.

RafalSkolasinski · 2020-12-06T21:32:19Z

Just hit that on OpenSuse Tumbleweed. Couldn't really fix it until I found the solution in fish-shell/fish-shell#7485 (comment).

AlienProber · 2020-12-06T22:49:16Z

Is this possibly related to my below issue?

#4005

Pingger · 2021-10-08T13:22:41Z

Can confirm this issue for
Manjaro 21.04
Fish 3.3.1

Full Info

Operating System: Manjaro Linux
KDE Plasma Version: 5.22.5
KDE Frameworks Version: 5.86.0
Qt Version: 5.15.2
Kernel Version: 5.13.19-2-MANJARO (64-bit)

Current workaround: chsh to /bin/bash

Zlopez · 2021-11-09T19:25:01Z

This is still happening on Fedora 35 Kinoite when /bin/fish is set as default shell. No flatpak apps are displayed or searchable in menu.

After switching to /bin/bash this was fixed.

smcv · 2021-11-10T12:38:56Z

If a fish user wants to contribute a tested snippet for fish's equivalent of profile.d, please open a merge request. I don't think any of the Flatpak maintainers use fish, so if fish users want better interop with Flatpak, we're relying on you to provide it.

What we would need is something equivalent to profile/flatpak.sh (used for bash and POSIX sh) and profile/flatpak.csh (used for tcsh and csh), but in fish syntax; plus code in Makefile.am to install it in the right place (again, the same as profile/flatpak.sh).

robbert-vdh · 2021-11-10T13:09:02Z

I have this in my fish configuration which probably doesn't do quite the same thing as profile/flatpak.sh, but it should be a start (it also doesn't take into account alternative $XDG_DATA_HOMEs and things like that):

if command -vq flatpak
    set -ga fish_user_paths ~/.local/share/flatpak/exports/bin /var/lib/flatpak/exports/bin
    set -gx --path XDG_DATA_DIRS ~/.local/share/flatpak/exports/share
    for install_dir in (flatpak --installations)
        set -gxa XDG_DATA_DIRS $install_dir/exports/share
    end
end

If Flatpak were to provide a /usr/share/fish/vendor_conf.d/flatpak.fish that does something similar then everything should work great out of the box.

Technically, Fish users can already make this work using https://github.com/edc/bass, but it's also nice to have this working on an out-of-the-box Flatpak installation. Fixes flatpak#3109. Signed-off-by: Ryan Gonzalez <[email protected]>

Technically, Fish users can already make this work using https://github.com/edc/bass, but it's also nice to have this working on an out-of-the-box Flatpak installation. Fixes #3109. Signed-off-by: Ryan Gonzalez <[email protected]>

rohrschacht · 2022-03-21T18:34:35Z

I have this in my fish configuration which probably doesn't do quite the same thing as profile/flatpak.sh, but it should be a start (it also doesn't take into account alternative $XDG_DATA_HOMEs and things like that):
if command -vq flatpak
    set -ga fish_user_paths ~/.local/share/flatpak/exports/bin /var/lib/flatpak/exports/bin
    set -gx --path XDG_DATA_DIRS ~/.local/share/flatpak/exports/share
    for install_dir in (flatpak --installations)
        set -gxa XDG_DATA_DIRS $install_dir/exports/share
    end
end
If Flatpak were to provide a /usr/share/fish/vendor_conf.d/flatpak.fish that does something similar then everything should work great out of the box.

I tested this snippet in my own config.fish, but it broke most of my system. The application launcher only showed flatpaks and no other programs anymore, and some applications crashed when logging in. The problem was that XDG_DATA_DIRS was empty before, and according to [1], when XDG_DATA_DIRS is empty, a default value of /usr/local/share/:/usr/share/ is assumed. After adding this to the variable, everything works really well for me now. This is the snippet I am now using in my config.fish:

if command -vq flatpak
    set -ga fish_user_paths ~/.local/share/flatpak/exports/bin /var/lib/flatpak/exports/bin
    set -gx --path XDG_DATA_DIRS /usr/local/share/ /usr/share/ ~/.local/share/flatpak/exports/share
    for install_dir in (flatpak --installations)
        set -gxa XDG_DATA_DIRS $install_dir/exports/share
    end
end

flatpak doesn't complain anymore, flatpaks are showing up in my application launchers, and the rest of my system is still working 👍

[1] https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

smcv · 2022-03-21T20:20:52Z

@rohrschacht, please could you test the version of this that got merged in #4575 (https://github.com/flatpak/flatpak/blob/1.13.2/profile/flatpak.fish)? And if that doesn't work or has things wrong with it, please report a new issue rather than replying to a closed issue.

Suggestions on an issue should not be interpreted as official, reviewed or correct unless they have actually been merged into the codebase.

dm17 · 2022-06-15T14:27:28Z

I guess there is an approve fix because this is closed? I just hit the issue. Is the solution from @rohrschacht above the final one?

smcv · 2022-06-15T15:37:29Z

If the version of this that is included in Flatpak releases is wrong, please report a new issue. Please do not reply to an issue that has been closed.

matthiasclasen added 3rd party integration enhancement labels Sep 21, 2019

robbert-vdh added a commit to robbert-vdh/dotfiles that referenced this issue Nov 22, 2020

Manually populate $XDG_DATA_DIRS

b033ca4

As a temporary workaround for flatpak/flatpak#3109.

ThisNekoGuy mentioned this issue Mar 6, 2021

SDDM 0.15.0 doesnt source /etc/profile.d/* anymore sddm/sddm#879

Closed

mwleeds mentioned this issue Nov 10, 2021

About something being printed during installation or update of apps #533

Closed

refi64 mentioned this issue Nov 13, 2021

Add a profile script for Fish #4575

Merged

alexlarsson closed this as completed in #4575 Nov 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XDG_DATA_DIRS is not set on fish shell #3109

XDG_DATA_DIRS is not set on fish shell #3109

qlem commented Sep 17, 2019 •

edited

TingPing commented Sep 17, 2019 •

edited

refi64 commented Sep 18, 2019 via email

qlem commented Sep 18, 2019

Poorchop commented Dec 14, 2019

matthiasclasen commented Dec 15, 2019

Poorchop commented Dec 15, 2019

TingPing commented Dec 15, 2019

adaigre commented Jan 26, 2020 •

edited

doums commented Apr 15, 2020

MatthiasGrandl commented May 6, 2020

corvore commented May 6, 2020

travankor commented May 9, 2020

matwey commented May 29, 2020

Vogtinator commented May 29, 2020

travankor commented May 29, 2020 •

edited

matwey commented May 29, 2020

travankor commented May 31, 2020 •

edited

refi64 commented Jun 4, 2020 via email

PureTryOut commented Nov 9, 2020

soredake commented Nov 9, 2020

sebastianwagner commented Nov 23, 2020

RafalSkolasinski commented Dec 6, 2020

AlienProber commented Dec 6, 2020 •

edited

Pingger commented Oct 8, 2021 •

edited

Zlopez commented Nov 9, 2021

smcv commented Nov 10, 2021

robbert-vdh commented Nov 10, 2021 •

edited

rohrschacht commented Mar 21, 2022

smcv commented Mar 21, 2022

dm17 commented Jun 15, 2022

smcv commented Jun 15, 2022

XDG_DATA_DIRS is not set on fish shell #3109

XDG_DATA_DIRS is not set on fish shell #3109

Comments

qlem commented Sep 17, 2019 • edited

Linux distribution and version

Flatpak version

Description of the problem

Steps to reproduce

TingPing commented Sep 17, 2019 • edited

refi64 commented Sep 18, 2019 via email

qlem commented Sep 18, 2019

Poorchop commented Dec 14, 2019

matthiasclasen commented Dec 15, 2019

Poorchop commented Dec 15, 2019

TingPing commented Dec 15, 2019

adaigre commented Jan 26, 2020 • edited

doums commented Apr 15, 2020

MatthiasGrandl commented May 6, 2020

corvore commented May 6, 2020

travankor commented May 9, 2020

matwey commented May 29, 2020

Vogtinator commented May 29, 2020

travankor commented May 29, 2020 • edited

matwey commented May 29, 2020

travankor commented May 31, 2020 • edited

refi64 commented Jun 4, 2020 via email

PureTryOut commented Nov 9, 2020

soredake commented Nov 9, 2020

sebastianwagner commented Nov 23, 2020

RafalSkolasinski commented Dec 6, 2020

AlienProber commented Dec 6, 2020 • edited

Pingger commented Oct 8, 2021 • edited

Zlopez commented Nov 9, 2021

smcv commented Nov 10, 2021

robbert-vdh commented Nov 10, 2021 • edited

rohrschacht commented Mar 21, 2022

smcv commented Mar 21, 2022

dm17 commented Jun 15, 2022

smcv commented Jun 15, 2022

qlem commented Sep 17, 2019 •

edited

TingPing commented Sep 17, 2019 •

edited

adaigre commented Jan 26, 2020 •

edited

travankor commented May 29, 2020 •

edited

travankor commented May 31, 2020 •

edited

AlienProber commented Dec 6, 2020 •

edited

Pingger commented Oct 8, 2021 •

edited

robbert-vdh commented Nov 10, 2021 •

edited