Skip to content

Commit

Permalink
flatpak-dir: For completeness, always add "--" to bwrap arguments
Browse files Browse the repository at this point in the history
This particular bwrap invocation cannot cause a sandbox escape because
the command to run is hard-coded, but it's more clearly correct if we
pass "--" to every bwrap invocation.

Signed-off-by: Simon McVittie <[email protected]>
  • Loading branch information
smcv committed Apr 17, 2024
1 parent bbab7ed commit c95214b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion common/flatpak-dir.c
Expand Up @@ -8385,7 +8385,7 @@ apply_extra_data (FlatpakDir *self,

flatpak_bwrap_envp_to_args (bwrap);

flatpak_bwrap_add_arg (bwrap, "/app/bin/apply_extra");
flatpak_bwrap_add_args (bwrap, "--", "/app/bin/apply_extra", NULL);

flatpak_bwrap_finish (bwrap);

Expand Down

0 comments on commit c95214b

Please sign in to comment.