Skip to content

Commit

Permalink
portal: Add a note about CLEAR_ENV behaviour
Browse files Browse the repository at this point in the history
This seems like something to fix later, outside embargo.

Signed-off-by: Simon McVittie <[email protected]>
  • Loading branch information
smcv authored and alexlarsson committed Jan 14, 2021
1 parent d19f6c3 commit 4ac1106
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions portal/flatpak-portal.c
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,11 @@ handle_spawn (PortalFlatpak *object,
fd_map[i].to = ++max_fd;
}

/* TODO: Ideally we should let `flatpak run` inherit the portal's
* environment, in case e.g. a LD_LIBRARY_PATH is needed to be able
* to run `flatpak run`, but tell it to start from a blank environment
* when running the Flatpak app; but this isn't currently possible, so
* for now we preserve existing behaviour. */
if (arg_flags & FLATPAK_SPAWN_FLAGS_CLEAR_ENV)
{
char *empty[] = { NULL };
Expand Down

0 comments on commit 4ac1106

Please sign in to comment.