Skip to content

Commit

Permalink
workflows: Explicitly enable/disable GObject-Introspection
Browse files Browse the repository at this point in the history
For the build that uses --enable-asan, explicitly disable introspection,
since the GObject-Introspection scanner works poorly with libtool
and AddressSanitizer (see #4844); the only reason this worked until
now is that --enable-asan doesn't currently do anything (again,
see #4844).

For the build that runs tests under valgrind, we already can't use
AddressSanitizer, making this a good place to explicitly enable
introspection, so that we have at least one build with it enabled.

Signed-off-by: Simon McVittie <[email protected]>
  • Loading branch information
smcv authored and alexlarsson committed May 3, 2022
1 parent cb73e09 commit 1e09311
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,12 @@ jobs:
- name: autogen.sh
run: NOCONFIGURE=1 ./autogen.sh
- name: configure
# We don't do gtk-doc or GObject-Introspection here, because they can
# clash with AddressSanitizer. Instead, the clang build enables those.
run: |
mkdir _build
pushd _build
../configure --enable-internal-checks --enable-asan
../configure --enable-internal-checks --enable-asan --disable-introspection
popd
env:
CFLAGS: -O2 -Wp,-D_FORTIFY_SOURCE=2
Expand Down Expand Up @@ -172,7 +174,7 @@ jobs:
run: |
mkdir _build
pushd _build
../configure --enable-gtk-doc --enable-gtk-doc-html
../configure --enable-gtk-doc --enable-gtk-doc-html --enable-introspection
popd
env:
CFLAGS: -O2
Expand Down

0 comments on commit 1e09311

Please sign in to comment.