Bump some of the deps #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilelmoussaoui
force-pushed
the
bilelmoussaoui/bump-deps
branch
from
660c6b8
to
e9e6eb5
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/bump-deps
branch
from
e9e6eb5
to
c303202
Compare
ranfdev
reviewed
Mar 13, 2023
There was a problem hiding this comment.
After a quick glance, looks good to me. Only one thing is a bit strange. In a point you used the base64 converter STANDARD and somewhere else STANDARD_NO_PAD.
You sure it's correct having different encodings? I don't know...
EDIT: ok, it was already like that before, so it's right
yes, it also has tests to ensure it is encoded/decoded correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining ones are somehow related to actix & futures usage