Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gamescope runtime extension #4329

Closed
wants to merge 1 commit into from
Closed

Add Gamescope runtime extension #4329

wants to merge 1 commit into from

Conversation

orowith2os
Copy link

@orowith2os orowith2os commented Jul 16, 2023 •
edited

Please confirm your submission meets all the criteria

  • I have read the App Requirements and App Maintenance pages.

  • My pull request follows the instructions at App Submission.

  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)

  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.

  • I am an upstream contributor to the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:

  • I own the domain used in the application ID or the domain has a policy for delegating subdomains (e.g. GitHub, SourceForge).

  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

  • glm needs a downstream workaround, they refuse to fix it upstream. See the appropriate comment for more details.

Closes flathub/com.valvesoftware.Steam.Utility.gamescope#59

@orowith2os
Copy link
Author

bot, build org.freedesktop.Platform.VulkanLayer.gamescope

@flathubbot
Copy link

Queued test build for org.freedesktop.Platform.VulkanLayer.gamescope.

@flathubbot
Copy link

Started test build 53323

@flathubbot
Copy link

Build 53323 failed

@orowith2os orowith2os force-pushed the org.freedesktop.Platform.VulkanLayer.gamescope branch from 1c6fd84 to a5900c5 Compare July 16, 2023 07:48
@orowith2os
Copy link
Author

bot, build org.freedesktop.Platform.VulkanLayer.gamescope

@flathubbot
Copy link

Queued test build for org.freedesktop.Platform.VulkanLayer.gamescope.

@flathubbot
Copy link

Started test build 53324

@flathubbot
Copy link

Build 53324 failed

@orowith2os
Copy link
Author

AArch64 troubles, mtdev doesn't want to work. Something about not recognizing the system. See the logs.

@orowith2os
Copy link
Author

org.freedesktop.Sdk builds mtdev just fine it looks like, I wonder why it's not working here?

@orowith2os orowith2os mentioned this pull request Jul 16, 2023
Open
2 tasks
@orowith2os
Copy link
Author

The script shipped by mtdev is outdated, it needs to be patched in. Noting this for when I wake up.

This was referenced Jul 16, 2023
Merged
Closed
Closed
Closed
@orowith2os orowith2os force-pushed the org.freedesktop.Platform.VulkanLayer.gamescope branch from a5900c5 to 49a8d71 Compare July 16, 2023 11:58
@orowith2os
Copy link
Author

bot, build org.freedesktop.Platform.VulkanLayer.gamescope

@flathubbot
Copy link

Queued test build for org.freedesktop.Platform.VulkanLayer.gamescope.

@flathubbot
Copy link

Started test build 53348

@flathubbot
Copy link

Build 53348 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/35988/org.freedesktop.Platform.VulkanLayer.gamescope.flatpakref

@orowith2os
Copy link
Author

Tested with Bottles and Spider-Man: Miles Morales, works beautifully. Will be poking at other games some more in the meantime, but I don't expect issues.

@orowith2os orowith2os force-pushed the org.freedesktop.Platform.VulkanLayer.gamescope branch from 49a8d71 to 57771c2 Compare July 16, 2023 12:13
orowith2os added a commit to orowith2os/org.prismlauncher.PrismLauncher that referenced this pull request Jul 16, 2023
@orowith2os
Use runtime-provided gamescope rather than Steam
34cfe00 
Depends on flathub/flathub#4329
Closes flathub#11
Required after flathub/com.valvesoftware.Steam.Utility.gamescope#150
@orowith2os orowith2os mentioned this pull request Jul 16, 2023
Merged
hfiguiere
hfiguiere reviewed Jul 16, 2023
View reviewed changes
modules/gamescope.yml Outdated Show resolved Hide resolved
hfiguiere
hfiguiere reviewed Jul 16, 2023
View reviewed changes
gamescope Outdated Show resolved Hide resolved
hfiguiere
hfiguiere reviewed Jul 16, 2023
View reviewed changes
modules/libinput.yml Outdated Show resolved Hide resolved
@orowith2os orowith2os force-pushed the org.freedesktop.Platform.VulkanLayer.gamescope branch from 57771c2 to b90e38a Compare July 16, 2023 14:31
@koplo199 koplo199 mentioned this pull request Jul 16, 2023
Merged
5 tasks
@hfiguiere
Copy link
Contributor

bot, build org.freedesktop.Platform.VulkanLayer.gamescope

@flathubbot
Copy link

Queued test build for org.freedesktop.Platform.VulkanLayer.gamescope.

@flathubbot
Copy link

Started test build 53435

@flathubbot
Copy link

Build 53435 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/36075/org.freedesktop.Platform.VulkanLayer.gamescope.flatpakref

@orowith2os
Copy link
Author

Tested again and all seems good.

@orowith2os orowith2os mentioned this pull request Jul 17, 2023
Draft
travier
travier reviewed Jul 17, 2023
View reviewed changes
flathub.json Outdated Show resolved Hide resolved
@orowith2os orowith2os force-pushed the org.freedesktop.Platform.VulkanLayer.gamescope branch 2 times, most recently from cbc8e31 to a58c183 Compare July 17, 2023 09:14
@travier
Copy link
Member

travier commented Jul 17, 2023

Hum, now there are two empty lines at the end of files. We only need one. Sorry for the nitpicking. :/

@orowith2os orowith2os force-pushed the org.freedesktop.Platform.VulkanLayer.gamescope branch from a58c183 to 315a718 Compare July 17, 2023 09:25
@orowith2os
Copy link
Author

Hum, now there are two empty lines at the end of files. We only need one. Sorry for the nitpicking. :/

Can you point me to em? I'm not sure what logic is used for eof empty lines, so I just made sure there was one full empty line on each.

Also, I shimmied things around a bit.

@orowith2os orowith2os force-pushed the org.freedesktop.Platform.VulkanLayer.gamescope branch from 315a718 to b4f928e Compare July 17, 2023 09:27
@travier
Copy link
Member

travier commented Jul 17, 2023

You can see them in all files in the GitHub view: https://github.com/flathub/flathub/pull/4329/files.
Depending on your text editor, you should see at least an empty line. Vim "hides" the empty line at EOF by default, but VSCode doesn't.

@orowith2os
Copy link
Author

This confuses me a bit. I recall there being no empty lines in some files, and it was just fine, but in others, like the flathub.json, it complains.

I'm also using neovim, fwiw.

@orowith2os
Add Gamescope runtime extension
4d17678 
Signed-off-by: Dallas Strouse <[email protected]>
@orowith2os orowith2os force-pushed the org.freedesktop.Platform.VulkanLayer.gamescope branch from b4f928e to 4d17678 Compare July 17, 2023 09:38
@orowith2os
Copy link
Author

Alright, I think that should work. I added an empty lines to manifests that GitHub didn't like, and removed ones for the ones it was fine with.

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/org.freedesktop.Platform.VulkanLayer.gamescope

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you have never maintained an application before, common questions are answered in the app maintenance guide.

Thanks!

@flathubbot flathubbot closed this Jul 17, 2023
@travier
Copy link
Member

travier commented Jul 17, 2023

Hum, as this is a runtime extension, shouldn't we have per-runtime version branches instead?

@orowith2os
Copy link
Author

We can do both, but it's probably better for it to have just per-runtime-version branches, yes.

@orowith2os
Copy link
Author

Done, thanks @TingPing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier left review comments

@hfiguiere hfiguiere Awaiting requested review from hfiguiere

@barthalion barthalion Awaiting requested review from barthalion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@orowith2os @flathubbot @hfiguiere @travier @barthalion