Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please consider making --command=steam go via the wrapper #1078

Closed
smcv opened this issue May 4, 2023 · 2 comments
Closed

Please consider making --command=steam go via the wrapper #1078

smcv opened this issue May 4, 2023 · 2 comments

Comments

@smcv
Copy link
Contributor

smcv commented May 4, 2023 •
edited

At the moment /app/bin/steam is Valve's bin_steam.sh (which users should never run directly in this Flatpak app), and /app/bin/steam-wrapper is the correct entry point for users (which does some necessary setup and then execs /app/bin/steam).

With flatpak/flatpak#5404 and flatpak/flatpak#5395 in mind, it might be better to have /app/bin/steam be the wrapper, and make it exec Valve's script as /app/lib/steam/bin_steam.sh (or via a symlink /app/lib/steam/steam after prepending /app/lib/steam to the PATH, if having it available in the PATH as steam is desirable).

That would make it less likely that users will get broken behaviour by running it with --command=steam. If flatpak/flatpak#5404 gets merged, it would also allow the steam executable to be exported as a more explicit entry point /var/lib/flatpak/com.valvesoftware.Steam+steam alongside /var/lib/flatpak/com.valvesoftware.Steam+steamcmd.

/app/bin/steamcmd is already a symlink to steamcmd-wrapper, ensuring that --command=steamcmd goes via the wrapper as expected, instead of running Valve's code directly.
@nanonyme
Copy link
Collaborator

@smcv this sounds fine, I actually considered it years back but wasn't sure if it was considered supported approach from Steam side.

nanonyme added a commit that referenced this issue Aug 13, 2023
@nanonyme
Make wrapper be /bin/steam
d70b60d 
As suggested by smcv in #1078 let's make /bin/steam be wrapper script.
This decreases probability of users accidentally bypassing wrapper
and getting unexpected end results and facilicates some future use
cases.
@nanonyme nanonyme mentioned this issue Aug 13, 2023
Merged
nanonyme added a commit that referenced this issue Aug 13, 2023
@nanonyme
Make wrapper be /bin/steam
950a96b 
As suggested by smcv in #1078 let's make /bin/steam be wrapper script.
This decreases probability of users accidentally bypassing wrapper
and getting unexpected end results and facilicates some future use
cases.
nanonyme added a commit that referenced this issue Aug 13, 2023
@nanonyme
Make wrapper be /bin/steam
61b5bf3 
As suggested by smcv in #1078 let's make /bin/steam be wrapper script.
This decreases probability of users accidentally bypassing wrapper
and getting unexpected end results and facilicates some future use
cases.
nanonyme added a commit that referenced this issue Aug 27, 2023
@nanonyme
Make wrapper be /bin/steam
01c5214 
As suggested by smcv in #1078 let's make /bin/steam be wrapper script.
This decreases probability of users accidentally bypassing wrapper
and getting unexpected end results and facilicates some future use
cases.
nanonyme added a commit that referenced this issue Aug 27, 2023
@nanonyme
Make wrapper be /bin/steam
a25bdf1 
As suggested by smcv in #1078 let's make /bin/steam be wrapper script.
This decreases probability of users accidentally bypassing wrapper
and getting unexpected end results and facilicates some future use
cases.
@nanonyme
Copy link
Collaborator

This is now changed in beta.

@rybak rybak mentioned this issue Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nanonyme @smcv