appstream: Require that appstream IDs match $FLATPAK_ID #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change, we need to put exceptions for everything listed in flathub/flathub#4222 (comment) |
bbhtt
force-pushed
the
require-matching-apstream-cid
branch
from
52331c6
to
65f73ac
Compare
|
Should be ready now |
bbhtt
force-pushed
the
require-matching-apstream-cid
branch
4 times, most recently
from
2f01776
to
e27f8d7
Compare
For historical reasons flatpak-builder passes ``$FLATPAK_ID.desktop` as a valid component ID to appstreamcli. This mismatch creates issues like the one described in flatpak/flatpak#5752 and flathub/flathub#4222 So require that both match and avoid new submissions leaking in with a mismatch.
for apps that predated this rule Add appstream-id-mismatch-flatpak-id to known exceptions in validator.py
bbhtt
force-pushed
the
require-matching-apstream-cid
branch
from
e27f8d7
to
80f026d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historical reasons flatpak-builder passes ``$FLATPAK_ID.desktop` as a valid component ID to appstreamcli. This mismatch creates issues like the one described in flatpak/flatpak#5752 and flathub/flathub#4222
So require that both match and avoid new submissions leaking in with a mismatch.