This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
fix spectrum color null as zero #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
suggested changes
Jun 3, 2021
Comment on lines
+581
to
+588
| if(bucket.value !== null) { | ||
| return this.colorScale(bucket.value); | ||
| } else { | ||
| if(this.panel.nullPointMode == 'as zero') { | ||
| return this.colorScale(0); | ||
| } | ||
| } | ||
| } else if (this.panel.color.mode === 'discrete') { |
There was a problem hiding this comment.
Hello! Thank you for your contribution!
I've run a plugin with the suggested change and it not work. Check for null is not working, because bucket.value may be "undefined". I've changed your code a bit and it works. Can you apply this suggestion?
Suggested change
| if(bucket.value !== null) { | |
| return this.colorScale(bucket.value); | |
| } else { | |
| if(this.panel.nullPointMode == 'as zero') { | |
| return this.colorScale(0); | |
| } | |
| } | |
| } else if (this.panel.color.mode === 'discrete') { | |
| if (!bucket.value && this.panel.nullPointMode === 'as zero') { | |
| // bucket.value === 0 falls here, but it is fine. | |
| return this.colorScale(0); | |
| } | |
| return this.colorScale(bucket.value); | |
| } else if (this.panel.color.mode === 'discrete') { |
albertoperdomo2
pushed a commit
to albertoperdomo2/grafana-statusmap
that referenced
this pull request
Dec 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix 'display as zero' mode for nulls when spectrum color is used.
What this PR does / why we need it
Without this fix nulls are displayed as black in 'as zero' mode.
Special notes for your reviewer
Does this PR introduce a user-facing change?