fix module converge on extender update #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Scherba <[email protected]>
b1c1b20
to
dd69b87
Compare
yalosev
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pr slightly updates ModuleManagerEventHandler's logic regarding processing events from Dynamic Extender.
Also, it bumps shell-operator to v1.4.9.
What this PR does / why we need it
The point is that we have to check the operator's converge Phase before deciding if we can put converge restart task in the beginning of the main queue. If converge hasn't start yet, it's highly likely there are some global hooks tasks in the main queue and we should let them run before restarting the converge process. Otherwise, some global values may be missing and restarting the converge ends up in a failure.
Special notes for your reviewer