Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flame_3d): Make shader api more useful #3085

Merged
merged 3 commits into from
Jul 22, 2024
Merged

feat(flame_3d): Make shader api more useful #3085

merged 3 commits into from
Jul 22, 2024

Conversation

wolfenrain
Copy link
Contributor

@wolfenrain wolfenrain commented Mar 19, 2024 •
edited
Loading

Description

BIG WIP

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

This was referenced Apr 27, 2024
Merged
Merged
luanpotter added a commit that referenced this pull request Apr 27, 2024
@luanpotter
feat(flame_3d): Fix minor nits on flame_3d (#3140)
fcebf30 
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Apr 27, 2024
@luanpotter
feat(flame_3d): Add helpful extension functions to Vector (#3141)
7610acb 
Add helpful extension functions to Vector classes, including tests.

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
@luanpotter luanpotter force-pushed the feat(flame_3d)-make-shader-api-more-useful branch from 4e9f73c to 82083c3 Compare April 27, 2024 21:39
@luanpotter luanpotter mentioned this pull request Jun 3, 2024
Merged
6 tasks
@luanpotter luanpotter marked this pull request as ready for review June 4, 2024 01:51
@Jennaellly
Copy link

I can't wait for this

@luanpotter luanpotter force-pushed the feat(flame_3d)-make-shader-api-more-useful branch from 085f037 to db1465f Compare July 9, 2024 01:39
@luanpotter luanpotter force-pushed the feat(flame_3d)-make-shader-api-more-useful branch from db1465f to a15f851 Compare July 9, 2024 23:14
@luanpotter
feat: Implement basic light abstraction [flame_3d] (#3182)
f40a1d0 
Implement a basic light abstraction.

Still only supports one light for now, and no parameters other than its
position.
Note: I will fix the 0-lights case when I add support for multiple
lights.

A few complications arose that led me to revamp our component system a
bit. Basically splitting the `Component3D` class into a more fundamental
version of itself that only includes the 3D positioning stuff, and none
of the rendering stuff, and what used to be `Component3D` becomes
`Object3D` (I am not sold on the names, feel free to suggest
replacements).

I also added a `Group3D` class to allow for people to create groups of
components without carrying the rendering code. Of course you can still
add children to Object3D as well. I am open to removing it and just
making `Component3D` concrete instead.

The image below explains the new structure:


![image](https://github.com/flame-engine/flame/assets/882703/6dcb408c-10ea-4b67-b4fc-d760a1d91ea0)

---

The difference between the 3 "light" classes:

* `LightComponent` → interacts with FCS. is Component3D, thus carries
the position
* `LightSource` → describes the light in abstract terms (minus
position). used both by `LightComponent` and `Light`
* `Light` → base description of a Light as a Resource. FCS agnostic.
includes properties (source) + position

Again, I am open to any renames.

---

## FAQ

#### why separate component3d and object 3d?

not really needed but I didn't want light component to "carry" the
rendering code that is not used. that also makes the distinction more
clear as objects are completely different than lights. that way we don't
have to have a definition of "non-light objects/components"

#### ~why do we need group3d?~

i removed group3d!

~again not really needed, you can add children to objects, but if you
want a pure container (no rendering), this would make more semantic
sense. other options would be to not have anything (tell people to group
things using object3d) or make component3d concrete (tell people to use
that). having group3d consolidates the separation of light as its own
thing.~

#### why some classes end in 3D and some classes end in Component

[answer](https://martinfowler.com/bliki/TwoHardThings.html) (please
help)
@luanpotter luanpotter merged commit c9cf609 into flame_3d Jul 22, 2024
3 of 8 checks passed
@luanpotter luanpotter deleted the feat(flame_3d)-make-shader-api-more-useful branch July 22, 2024 20:25
luanpotter added a commit that referenced this pull request Jul 23, 2024
@luanpotter
feat(flame_3d): Fix minor nits on flame_3d (#3140)
8a3deb6 
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Jul 23, 2024
@luanpotter
feat(flame_3d): Add helpful extension functions to Vector (#3141)
cd74744 
Add helpful extension functions to Vector classes, including tests.

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Jul 23, 2024
@wolfenrain @luanpotter
feat(flame_3d): Make shader api more useful (#3085)
4139ee6 
Co-authored-by: Luan Nico <[email protected]>
luanpotter added a commit that referenced this pull request Jul 27, 2024
@luanpotter
feat(flame_3d): Fix minor nits on flame_3d (#3140)
b4fff98 
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Jul 27, 2024
@luanpotter
feat(flame_3d): Add helpful extension functions to Vector (#3141)
1dc99b9 
Add helpful extension functions to Vector classes, including tests.

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Jul 27, 2024
@wolfenrain @luanpotter
feat(flame_3d): Make shader api more useful (#3085)
8bdcfb8 
Co-authored-by: Luan Nico <[email protected]>
luanpotter added a commit that referenced this pull request Aug 12, 2024
@luanpotter
feat(flame_3d): Fix minor nits on flame_3d (#3140)
76fab17 
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Aug 12, 2024
@luanpotter
feat(flame_3d): Add helpful extension functions to Vector (#3141)
9a030ab 
Add helpful extension functions to Vector classes, including tests.

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Aug 12, 2024
@wolfenrain @luanpotter
feat(flame_3d): Make shader api more useful (#3085)
c519c9b 
Co-authored-by: Luan Nico <[email protected]>
luanpotter added a commit that referenced this pull request Aug 25, 2024
@luanpotter
feat(flame_3d): Fix minor nits on flame_3d (#3140)
7a647bb 
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Aug 25, 2024
@luanpotter
feat(flame_3d): Add helpful extension functions to Vector (#3141)
22349a0 
Add helpful extension functions to Vector classes, including tests.

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Aug 25, 2024
@wolfenrain @luanpotter
feat(flame_3d): Make shader api more useful (#3085)
579b956 
Co-authored-by: Luan Nico <[email protected]>
luanpotter added a commit that referenced this pull request Sep 11, 2024
@luanpotter
feat(flame_3d): Fix minor nits on flame_3d (#3140)
11cdfb5 
Fix minor nits on flame_3d, namely:

* fix wrong bash command on the readme file
* add missing git ignore to the example

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Sep 11, 2024
@luanpotter
feat(flame_3d): Add helpful extension functions to Vector (#3141)
9219598 
Add helpful extension functions to Vector classes, including tests.

This was extracted directly from @wolfenrain 's [bigger
PR](#3085), making it easier
to merge later.
luanpotter added a commit that referenced this pull request Sep 11, 2024
@wolfenrain @luanpotter
feat(flame_3d): Make shader api more useful (#3085)
fe2e4f2 
Co-authored-by: Luan Nico <[email protected]>
luanpotter added a commit that referenced this pull request Oct 15, 2024
@luanpotter
feat(flame_3d): Fix minor nits on flame_3d (#3140)