Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive: Fix Hungarian Notation #416

Conversation

NeoQuix
Copy link
Collaborator

@NeoQuix NeoQuix commented Jun 11, 2024

Fix correct branch base.

@NeoQuix NeoQuix self-assigned this Jun 11, 2024
@NeoQuix
Copy link
Collaborator Author

NeoQuix commented Jun 11, 2024

Code looks good at first glance.
Will check the tests and corner cases (tmp variables) etc. tomorrow.

@NeoQuix
Copy link
Collaborator Author

NeoQuix commented Jun 12, 2024

Code looks good, passes almost all tests/corner cases.

  1. Not so sure about L.78/79 with the different types. Possibly a future issue.
  2. If we have two arrays with the same base type but different sizes, they get assigned the same name. The problem is, that they technically have a different type (char [x] vs char[y]), but the _hungarian_prefix will return the same prefix for both of them, because the prefix is only based on the type and not the size.
    => Add prefix based on size or strip var_type size before adding to the counter in Z.83

@NeoQuix NeoQuix force-pushed the fix-hungarian-notation branch 3 times, most recently from a8efb32 to dd00433 Compare June 13, 2024 07:59
@NeoQuix NeoQuix merged commit 306a07d into issue-309-_Hungarian_Notation_Variables_with_different_names_but_same_labels_are_renamed_to_the_same_variable Jun 19, 2024
1 check passed
@NeoQuix NeoQuix deleted the fix-hungarian-notation branch June 19, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants