Improve error handling of decompilation tasks #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rihi
force-pushed
the
improve-error-handling
branch
2 times, most recently
from
ad19bbe
to
1f7b5f9
Compare
…tion for reanalysis
rihi
force-pushed
the
improve-error-handling
branch
from
1f7b5f9
to
4fba3dd
Compare
ebehner
previously approved these changes
Apr 3, 2024
ebehner
reviewed
Apr 4, 2024
# Conflicts: # tests/pipeline/controlflowanalysis/restructuring_commons/test_condition_aware_refinement.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the error handling of the decompilation process.
Previously, error raised before cfg lifting, like during lifting of the function signature, were simply not caught. This resulted in
decompile_allcrashing if one function failed before cfg lifting.We do however already have a mechanism for failed function decompilation, which is that the decompiler taks object created for each function can be marked as 'failed'. This PR makes sure that these kinds of errors are now also caught with this in mind.
Additionally, this PR fixes #291, by checking if binary ninja decompiled the function successfully and failing with the appropriated reason if not.
Additionally this PR has two commits which slightly refactor some code 0759650, 2cd2a36. These are not directly needed to fix any bug, and could be dropped if desired.