The Great Pcode Extractor Refactoring #472
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vobst
force-pushed
the
pcode_extractor_refactoring
branch
from
16a9df3
to
1a790e8
Compare
Replace the Pcode Extractor plugin with a stripped-down version that is not doing any processing. Its job is just to obtain the relevant data from the Ghidra APIs and to hand it over to the Rust side, where all of the processing will be done.
vobst
force-pushed
the
pcode_extractor_refactoring
branch
from
1a790e8
to
9fe7810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: While in draft state, this PR will be force pushed without notice.
tl;dr: The goal of this PR is to simplify the Ghidra plugin by moving all of the pcode transformations to the Rust side.