Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix upload submit bug #760

Merged
merged 2 commits into from
Apr 6, 2022
Merged

fix upload submit bug #760

merged 2 commits into from
Apr 6, 2022

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Apr 5, 2022

Fixed a bug in the upload template where the POST request to /upload was not triggered on some systems
Resolves #750, resolves #757

@jstucke jstucke added the bug label Apr 5, 2022
@jstucke jstucke requested a review from rhelmke April 5, 2022 07:24
@jstucke jstucke self-assigned this Apr 5, 2022
@jstucke jstucke mentioned this pull request Apr 5, 2022
Closed
rhelmke
rhelmke approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@rhelmke rhelmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix seems to work, great! Thank you very much

@rhelmke rhelmke merged commit 0e8a0bf into master Apr 6, 2022
@jstucke jstucke mentioned this pull request Apr 7, 2022
Closed
@jstucke jstucke deleted the upload-submit-bugfix branch April 27, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhelmke rhelmke rhelmke approved these changes

Assignees

@jstucke jstucke

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firmware not uploading? Not working anymore ?
2 participants
@jstucke @rhelmke