Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in cve_lookup setup + improved error logging #569

Merged
merged 3 commits into from
Apr 23, 2021

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Apr 22, 2021

resolves #568

there were some problems with the setup of the cve_lookup plugin:

  • CVE entries can have CPE names with colons (which breaks parsing)
  • there are new (broken?) CPE entries without "cpe23Uri"
  • improved (more informative) error logging

@jstucke jstucke added the bug label Apr 22, 2021
@jstucke jstucke requested a review from dorpvom April 22, 2021 12:27
@jstucke jstucke self-assigned this Apr 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #569 (859788f) into master (c90e7e5) will increase coverage by 0.08%.
The diff coverage is 78.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   95.55%   95.64%   +0.08%     
==========================================
  Files         307      307              
  Lines       18035    18464     +429     
==========================================
+ Hits        17234    17660     +426     
- Misses        801      804       +3     
Impacted Files Coverage Δ
...analysis/cve_lookup/internal/database_interface.py 90.76% <37.50%> (-1.04%) ⬇️
...ugins/analysis/cve_lookup/internal/data_parsing.py 87.35% <60.00%> (-1.93%) ⬇️
...s/analysis/cve_lookup/internal/setup_repository.py 82.77% <100.00%> (ø)
...nalysis/cve_lookup/test/test_database_interface.py 88.88% <100.00%> (ø)
.../analysis/cve_lookup/test/test_setup_repository.py 96.21% <100.00%> (+0.25%) ⬆️
src/compare/PluginBase.py 100.00% <0.00%> (ø)
src/helperFunctions/hash.py 100.00% <0.00%> (ø)
src/test/acceptance/auth_base.py 100.00% <0.00%> (ø)
src/test/acceptance/test_misc.py 100.00% <0.00%> (ø)
src/test/unit/test_manage_users.py 100.00% <0.00%> (ø)
... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90e7e5...859788f. Read the comment docs.

@dorpvom dorpvom merged commit afab103 into master Apr 23, 2021
@dorpvom dorpvom deleted the 568-fix-cve-lookup-setup branch April 23, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cve_lookup installation fails seemingly at random
3 participants