-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added statistics endpoints and tests #542
Conversation
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
=======================================
Coverage 95.62% 95.63%
=======================================
Files 304 306 +2
Lines 18311 18371 +60
=======================================
+ Hits 17510 17569 +59
- Misses 801 802 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine already. It just needs bit of refactoring and tweaking the tests a little
def test_rest_request_single_statistic(self): | ||
st = self.test_client.get('/rest/statistics/known_vulnerabilities', follow_redirects=True) | ||
|
||
assert b'known_vulnerabilities' in st.data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would make sense to also check that 'file_type' is not included in the result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lintly has detected code quality issues in this pull request.
No description provided.