Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and test coverage #522

Merged
merged 6 commits into from
Dec 9, 2020
Merged

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Dec 4, 2020

  • fixed naming collision in test
  • added flake8 config file
  • added flake8 github action

@jstucke jstucke requested a review from dorpvom December 4, 2020 09:00
@jstucke jstucke self-assigned this Dec 4, 2020
@codecov-io
Copy link

codecov-io commented Dec 4, 2020

Codecov Report

Merging #522 (797cf12) into master (d768e7d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files         302      302           
  Lines       18193    18193           
=======================================
  Hits        17395    17395           
  Misses        798      798           
Impacted Files Coverage Δ
...ion/scheduler/test_regression_virtual_file_path.py 98.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d768e7d...797cf12. Read the comment docs.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintly has detected code quality issues in this pull request.

@dorpvom dorpvom merged commit a6cd8fc into master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants