Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added yara_binary_search docs #520

Merged
merged 2 commits into from
Dec 11, 2020
Merged

added yara_binary_search docs #520

merged 2 commits into from
Dec 11, 2020

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Nov 26, 2020

No description provided.

@jstucke jstucke added the docs documentation label Nov 26, 2020
@jstucke jstucke requested a review from dorpvom November 26, 2020 15:48
@jstucke jstucke self-assigned this Nov 26, 2020
@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #520 (10a6286) into master (479906e) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
+ Coverage   95.47%   95.57%   +0.10%     
==========================================
  Files         302      302              
  Lines       17684    18089     +405     
==========================================
+ Hits        16883    17288     +405     
  Misses        801      801              
Impacted Files Coverage Δ
src/helperFunctions/yara_binary_search.py 100.00% <100.00%> (ø)
src/compare/PluginBase.py 100.00% <0.00%> (ø)
src/helperFunctions/hash.py 100.00% <0.00%> (ø)
src/test/acceptance/auth_base.py 100.00% <0.00%> (ø)
src/test/acceptance/test_misc.py 100.00% <0.00%> (ø)
src/test/unit/test_manage_users.py 100.00% <0.00%> (ø)
src/web_interface/rest/rest_base.py 100.00% <0.00%> (ø)
src/web_interface/rest/rest_binary.py 100.00% <0.00%> (ø)
src/test/unit/objects/test_firmware.py 100.00% <0.00%> (ø)
src/test/unit/scheduler/test_unpack.py 100.00% <0.00%> (ø)
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479906e...86b095b. Read the comment docs.

src/helperFunctions/yara_binary_search.py Show resolved Hide resolved
@@ -12,23 +13,30 @@


class YaraBinarySearchScanner:
'''
A scanner for searching with YARA rules on the binaries belonging to the firmware and file objects contained
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think we can improve the wording here. How 'bout:

This class provides functionality to scan files in the database for yara patterns. The public method allows to either match a given set of patterns on all files in the database or focus only on files included in a single firmware.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree → changed

@dorpvom dorpvom merged commit 3346ddc into master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants