Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stabilizer.cpp] fix com height of LIPM in Capture Point calculation #924

Merged
merged 1 commit into from
Dec 26, 2015

Conversation

eisoku9618
Copy link
Contributor

@snozawa @YutaKojio

CPの計算式はこうではないでしょか?

  • act_cog / act_cogvel / act_zmp は全部 foot_origin座標系相対
  • foot_origin座標系のz方向は重力ベクトルの反対方向と一致
  • foot_origin座標系の原点は足先リンク座標系の原点と一致
  • CPの計算式に出てくるzは倒立振子の高さ

という理解で合っているとすると

(elt
 (v-
  (send (send (car (send *robot* :rleg :force-sensors)) :parent) :worldpos)
  (send (send *robot* :rleg :end-coords) :worldpos))
 2)

の分だけずれているように思いました.

@k-okada
Copy link
Contributor

k-okada commented Dec 24, 2015

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2501/
Test PASSed.

@YutaKojio
Copy link
Contributor

はい.こちらのほうが正確だと思います.
すみませんが,ref_cpも同じように変更お願いします.
https://github.com/eisoku9618/hrpsys-base/blob/patch-1/rtc/Stabilizer/Stabilizer.cpp#L1037

@k-okada
Copy link
Contributor

k-okada commented Dec 25, 2015

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2504/
Test PASSed.

@eisoku9618
Copy link
Contributor Author

ref_cpも同じように変更しました.

@snozawa
Copy link
Contributor

snozawa commented Dec 26, 2015

LGTM。
travisも通ってるようですので、お手すきのときにご確認いただけますと幸いです。

fkanehiro added a commit that referenced this pull request Dec 26, 2015
[Stabilizer.cpp] fix com height of LIPM in Capture Point calculation
@fkanehiro fkanehiro merged commit 4300807 into fkanehiro:master Dec 26, 2015
@eisoku9618 eisoku9618 deleted the patch-1 branch December 26, 2015 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants