Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDLUtil.cpp] SDLwindow::~SDLwindow, call SDL_Quit only when this object is initialized #524

Merged
merged 1 commit into from
Mar 18, 2015
Merged

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Mar 18, 2015

No description provided.

@k-okada
Copy link
Contributor Author

k-okada commented Mar 18, 2015

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/1849/
Test PASSed.

@fkanehiro fkanehiro merged commit 716a653 into fkanehiro:master Mar 18, 2015
@fkanehiro
Copy link
Owner

#525 とかぶってる?

@k-okada k-okada deleted the fix_sdl_window branch March 18, 2015 16:04
@k-okada
Copy link
Contributor Author

k-okada commented Mar 18, 2015

はい.同じcommitを両方のbranchで使っているので大丈夫だと思います.

ところで,CollisionDetectorをrmするとsegfaultしていて,このPR+以下のようにexit()ではなくてdelete_compoentすると,
とりあえずは死なない,という状態なんですが,後どこを直したらいいかわかったりしますでしょうか?

ref = self.ref.delete_component(name)
#ref = findRTC(name).ref.exit() # delte_component did not
actually kill component, so use rtc.exit

#512 (comment)

◉ Kei Okada

On Thu, Mar 19, 2015 at 12:07 AM, Fumio KANEHIRO
[email protected] wrote:

#525 とかぶってる?


Reply to this email directly or view it on GitHub.

@fkanehiro
Copy link
Owner

以下のようなスクリプトではsegfaultすることはありませんが、どのようにすると落ちるかできるだけ簡単な再現方法を示してもらえないでしょうか。

import rtm

rtm.initCORBA()

comp = "CollisionDetector"
ms = rtm.findRTCmanager()
ms.load(comp)
rtc = ms.create(comp)
rtc.ref.exit()

2015-03-19 1:06 GMT+09:00 Kei Okada [email protected]:

はい.同じcommitを両方のbranchで使っているので大丈夫だと思います.

ところで,CollisionDetectorをrmするとsegfaultしていて,このPR+以下のようにexit()ではなくてdelete_compoentすると,

とりあえずは死なない,という状態なんですが,後どこを直したらいいかわかったりしますでしょうか?

ref = self.ref.delete_component(name)
#ref = findRTC(name).ref.exit() # delte_component did not
actually kill component, so use rtc.exit

#512 (comment)

◉ Kei Okada

On Thu, Mar 19, 2015 at 12:07 AM, Fumio KANEHIRO
[email protected] wrote:

#525 とかぶってる?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#524 (comment).

@k-okada
Copy link
Contributor Author

k-okada commented Mar 19, 2015

from hrpsys import hrpsys_config
import OpenHRP

h = hrpsys_config.HrpsysConfigurator()
h.init('SampleRobot(Robot)0')
#h.co.stop()
h.deleteComp('co')
print("done")

でsegfaultするはずですが,動いちゃっているきがします.うーん.治った?

◉ Kei Okada

On Thu, Mar 19, 2015 at 11:59 AM, Fumio KANEHIRO
[email protected] wrote:

以下のようなスクリプトではsegfaultすることはありませんが、どのようにすると落ちるかできるだけ簡単な再現方法を示してもらえないでしょうか。

import rtm

rtm.initCORBA()

comp = "CollisionDetector"
ms = rtm.findRTCmanager()
ms.load(comp)
rtc = ms.create(comp)
rtc.ref.exit()

2015-03-19 1:06 GMT+09:00 Kei Okada [email protected]:

はい.同じcommitを両方のbranchで使っているので大丈夫だと思います.

ところで,CollisionDetectorをrmするとsegfaultしていて,このPR+以下のようにexit()ではなくてdelete_compoentすると,

とりあえずは死なない,という状態なんですが,後どこを直したらいいかわかったりしますでしょうか?

ref = self.ref.delete_component(name)
#ref = findRTC(name).ref.exit() # delte_component did not
actually kill component, so use rtc.exit

#512 (comment)

◉ Kei Okada

On Thu, Mar 19, 2015 at 12:07 AM, Fumio KANEHIRO
[email protected] wrote:

#525 とかぶってる?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#524 (comment).


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants