support KUBECONFIG with multiple kube config files #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Carl <[email protected]>
|
this fixes #821 |
life1347
reviewed
Mar 27, 2019
There was a problem hiding this comment.
Hi @grounded042 thanks for the PR! It looks in good shape except one minor comment.
fission/util/util.go
Outdated
|
|
||
| kubeConfigPath := os.Getenv("KUBECONFIG") | ||
| if len(kubeConfigPath) == 0 { | ||
| home := os.Getenv("HOME") |
There was a problem hiding this comment.
To support windows better, I suggest here we can use os/user to get the correct home directory path.
reference: https://stackoverflow.com/a/13004756
There was a problem hiding this comment.
Thanks! I'll take a look.
There was a problem hiding this comment.
@life1347 I changed things up as per the link. Seems like a better cross-platform implementation.
…users home dir Signed-off-by: Jon Carl <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is