Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove buffered argument from perf observe call #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove buffered argument from perf observe call #5

wants to merge 2 commits into from

Conversation

Sc4ramouche
Copy link

@Sc4ramouche Sc4ramouche commented Dec 28, 2023 •
edited
Loading

Adresses #4, as providing both buffered and entryTypes causes a runtime error in Firefox, source — MDN spec.

TODO: perhaps we'd also need to re-zip femmpublic.zip for a proper fix.

sajidsalman75
sajidsalman75 reviewed Apr 5, 2024
View reviewed changes
Copy link

@sajidsalman75 sajidsalman75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is "}" missing at the end.
obs.observe({entryTypes: ["largest-contentful-paint", "layout-shift", "first-input", "paint"]});

@harsh-m-patil
Copy link

Thanks was having the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajidsalman75 sajidsalman75 sajidsalman75 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sc4ramouche @harsh-m-patil @sajidsalman75