New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style for consistency #423

Merged

bshaffer merged 1 commit into firebase:main from Krisell:style/array-syntax

Apr 23, 2022

Krisell commented Apr 23, 2022 •

edited

Loading

This PR fixes two minor style inconsistencies:

Short array syntax is used in the README (used in all code since feat: add typing for PHP 8.0 #385)
Single quotes are used for strings where possible (that seems to be the project standard)

Style aspects like this should preferably be enforced by code analysis tools (like php-cs-fixer).


Fix style for consistency

dcae46b

bshaffer approved these changes

View reviewed changes

bshaffer merged commit 0ac5041 into firebase:main

Collaborator

bshaffer commented Apr 23, 2022

Thank you for submitting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment