Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_crashlytics] Remove WorkspaceSettings.xcsettings #2152

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Mar 10, 2020

Description

Removes the iOS example app's xcsettings file that shouldn't be checked in and is interfering with Cirrus builds.

Related Issues

flutter/plugins#2592 - I believe this fixed the build on Cirrus for flutter/plugins, so hopefully it will do that here too.
#2099 - PR waiting for this fix to land on green

@collinjackson collinjackson changed the title Remove WorkspaceSettings.xcsettings [firebase_crashlytics] Remove WorkspaceSettings.xcsettings Mar 10, 2020
Copy link
Contributor

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants