Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement linkProviderUserInfo in auth emulator #6291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paulrostorp
Copy link

@paulrostorp paulrostorp commented Aug 23, 2023

Description

This PR addresses #4170. It adds an implementation for linkProviderUserInfo to the auth emulator

Scenarios Tested

Sample Commands

@google-cla
Copy link

google-cla bot commented Aug 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@@ -1185,8 +1181,22 @@ export function setAccountInfoImpl(
}
}

if (reqBody.linkProviderUserInfo) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please add a test to src/test/emulators/auth/setAccountInfo.spec.ts that covers the changes. The changes otherwise look great. Let me know if you need any help

@lisajian lisajian self-assigned this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants