Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove isArray, filter, reject, isNull #4666

Merged
merged 6 commits into from
Jun 17, 2022
Merged

remove isArray, filter, reject, isNull #4666

merged 6 commits into from
Jun 17, 2022

Conversation

bkendall
Copy link
Contributor

Description

removes isArray, filter, reject, and isNull

Also fixes a bug where the checkValidTargetFilters was checking every character in the only string instead of each thing split by a comma. That was interesting to find.

@bkendall bkendall requested a review from joehan June 17, 2022 16:26
joehan
joehan requested changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a logic error that we should fix while were here

src/checkValidTargetFilters.ts Outdated Show resolved Hide resolved
@bkendall bkendall requested a review from joehan June 17, 2022 17:49
joehan
joehan approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the leftover console.error

src/checkValidTargetFilters.ts Outdated Show resolved Hide resolved
@bkendall bkendall merged commit 28589f0 into master Jun 17, 2022
@bkendall bkendall deleted the bk-ldsh branch June 17, 2022 19:15
@Burgov Burgov mentioned this pull request Jul 1, 2022
Closed
@erno erno mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehan joehan joehan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bkendall @joehan