Inherit env and disable noop piping for emulators:exec. #1340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes the script of
firestore emulators:exec
inherit the environment variables (e.g.PATH
). This should make surefirestore emulators:exec "npm test"
always uses the local npm as expected.It also disables piping of
stdout
andstderr
since we're not changing them in anyway. As a nice side benefit, most CLI tools will now detect stdout as a terminal and turn on nice coloring, etc.Scenarios Tested
Manually:
firestore emulators:exec "env"
to make sure environment variables are inherited. (As opposed to before where it only has the firestore emulator env var.) Also, manuallyfirestore emulators:exec "which node"
now correctly shows my local nvm node.Manually
firestore emulators:exec "npm test"
inquickstart-nodejs/firestore-emulator/typescript-quickstart
to make sure mocha prints nice colored output, as opposed to no colors before.