Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JSON schema more usable #3528

Open
3 tasks
samtstern opened this issue Jun 23, 2021 · 4 comments
Open
3 tasks

Make JSON schema more usable #3528

samtstern opened this issue Jun 23, 2021 · 4 comments
Assignees
@joehan
Labels
polish Small feature requests

Comments

@samtstern
Copy link
Contributor

Follow up to #3505

TODO:

  • Publish the schema somewhere
  • Include $schema in firebase.json templates
  • Make schema errors more visible in the logs
@samtstern samtstern self-assigned this Jun 23, 2021
@samtstern samtstern added the polish Small feature requests label Jun 23, 2021
@samtstern
Copy link
Contributor Author

@abeisgoat think we could publish the schema on firebase.tools?

@samtstern samtstern removed their assignment Jul 16, 2021
@segevfiner
Copy link

You also need to allow "$schema" in the schema itself.

image

segevfiner added a commit to segevfiner/firebase-tools that referenced this issue Aug 23, 2022
@segevfiner
Allow top-level $schema property
5760985 
Related to firebase#3528

This allows specifying the schema for validation and completion like so:
```json
  "$schema": "./node_modules/firebase-tools/schema/firebase-config.json",
```
@segevfiner segevfiner mentioned this issue Aug 23, 2022
Open
@dominicbartl dominicbartl mentioned this issue Jun 28, 2023
Merged
@dominicbartl
Copy link
Contributor

@samtstern I created an updated PR to allow the top-level $schema property. It would be awesome if you could review this very simple change or add someone else as a reviewer. 😃

@joehan joehan self-assigned this Jun 28, 2023
@joehan
Copy link
Contributor

joehan commented Jun 28, 2023

Happened to be working on this, but never saw this issue. - thanks for highlighting it @dominicbartl!

We've also added this to the JSON schema store, so many IDEs should pick it up by default (or once you add the necessary plugins): https://github.com/SchemaStore/schemastore/blob/master/src/api/json/catalog.json#L1615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joehan joehan

Labels
polish Small feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dominicbartl @joehan @samtstern @segevfiner