Fix bug where CLI was unable to deploy Firebase Functions in some mon…

…orepo setups (#5391)

Partially fixes #4952.

#5215 made changes to the CLI to detect Functions SDK even in monorepo setups where Functions SDK is hoisted (i.e. Functions SDK dependency is declared in the parent directory but not in the sub-package directory).

We should've made corresponding change in how the Functions SDK binary is executed - instead of always looking up the sub-package's `node_modules`, we should be looking at the `node_modules` closest to where the Functions SDK dependency is declared.

This setup seems common in scenarios where the developer bundles the functions source using bundlers like vite/webpack/etc. This kind of technique has shown to help [AWS lambda's cold start time](https://aws.amazon.com/blogs/compute/optimizing-node-js-dependencies-in-aws-lambda/), and I think it's something we'd want to explore in Google Cloud Functions too.

CHANGELOG.md

@@ -0,0 +1 @@
+- Fix bug where CLI was unable to deploy Firebase Functions in some monorepo setups (#5391)

scripts/functions-discover-tests/fixtures/bundled/dist/index.js

@@ -0,0 +1,20 @@
+/**
+ * Minimal example of a "bundled" function source.
+ *
+ * Instead of actually bundling the source code, we manually annotate
+ * the exported function with the __endpoint property to test the situation
+ * where the distributed package doesn't include Firebase Functions SDK as a
+ * dependency.
+ */
+
+const hello = (req, resp) => {
+ resp.send("hello");
+};
+
+hello.__endpoint = {
+ platform: "gcfv2",
+ region: "region",
+ httpsTrigger: {},
+};
+
+exports.hello = hello;

scripts/functions-discover-tests/fixtures/bundled/dist/package.json

@@ -0,0 +1,7 @@
+{
+ "name": "dist",
+ "version": "0.0.1",
+ "engines": {
+ "node": "16"
+ }
+}

scripts/functions-discover-tests/fixtures/bundled/firebase.json

@@ -0,0 +1,5 @@
+{
+ "functions": {
+ "source": "dist"
+ }
+}

scripts/functions-discover-tests/fixtures/bundled/install.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+set -euxo pipefail # bash strict mode
+IFS=$'\n\t'
+
+npm i

scripts/functions-discover-tests/fixtures/bundled/package.json

@@ -0,0 +1,10 @@
+{
+ "name": "dist",
+ "version": "0.0.1",
+ "dependencies": {
+ "firebase-functions": "^4.1.1"
+ },
+ "engines": {
+ "node": "16"
+ }
+}

scripts/functions-discover-tests/tests.ts

@@ -67,6 +67,16 @@ describe("Function discovery test", function (this) {
  },
  ],
  },
+ {
+ name: "bundled",
+ projectDir: "bundled",
+ expects: [
+ {
+ codebase: "default",
+ endpoints: ["hello"],
+ },
+ ],
+ },
  ];
 
  for (const tc of testCases) {

src/deploy/functions/runtimes/node/index.ts

@@ -108,7 +108,12 @@ export class Delegate {
  if (Object.keys(config || {}).length) {
  env.CLOUD_RUNTIME_CONFIG = JSON.stringify(config);
  }
- const childProcess = spawn("./node_modules/.bin/firebase-functions", [this.sourceDir], {
+ // At this point, we've already confirmed that we found supported firebase functions sdk.
+ const sdkPath = require.resolve("firebase-functions", { paths: [this.sourceDir] });
+ // Find location of the closest node_modules/ directory where we found the sdk.
+ const binPath = sdkPath.substring(0, sdkPath.lastIndexOf("node_modules") + 12);
+ // And execute the binary included in the sdk.
+ const childProcess = spawn(path.join(binPath, ".bin", "firebase-functions"), [this.sourceDir], {
  env,
  cwd: this.sourceDir,
  stdio: [/* stdin=*/ "ignore", /* stdout=*/ "pipe", /* stderr=*/ "inherit"],