Skip to content

Commit

Permalink
Revert "show loader when functions are deploying" (#125)
Browse files Browse the repository at this point in the history
* Revert "show loader when functions are deploying"

* fix travis issue by not using Node 7
  • Loading branch information
laurenzlong committed Oct 25, 2016
1 parent e038a57 commit 4b9171b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ node_js:
- '0.10'
- '0.12'
- '4'
- stable
- '6'
sudo: false
after_script:
- cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js
Expand Down
6 changes: 0 additions & 6 deletions lib/deploy/functions/release.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ var logger = require('../../logger');
var FirebaseError = require('../../error');
var chalk = require('chalk');
var api = require('../../api');
var Spinner = require('cli-spinner').Spinner;

module.exports = function(context, options, payload) {
if (!options.config.has('functions')) {
Expand Down Expand Up @@ -224,17 +223,12 @@ module.exports = function(context, options, payload) {

return RSVP.allSettled([].concat(addOps, updateOps, deleteOps));
}).then(function(allOps) {
var spinner = new Spinner(chalk.bold.cyan('%s functions: ') + 'deploy in progress...');
spinner.setSpinnerString(19);
spinner.setSpinnerDelay(100);
spinner.start();
var failedCalls = _.chain(allOps).filter({'state': 'rejected'}).map('reason').value();
var successfulCalls = _.chain(allOps).filter({'state': 'fulfilled'}).map('value').value();
var fetch = _fetchTriggerUrls(successfulCalls);
var poll = _pollOperations(successfulCalls);

return RSVP.allSettled([fetch, poll]).then(function() {
spinner.stop(true);
return _reportResults(successfulCalls, failedCalls);
});
}).catch(function() {
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"archiver": "^0.16.0",
"chalk": "^1.1.0",
"cjson": "^0.3.1",
"cli-spinner": "^0.2.5",
"cli-table": "^0.3.1",
"commander": "^2.8.1",
"concat-stream": "^1.5.0",
Expand Down

0 comments on commit 4b9171b

Please sign in to comment.