fix: Fix a typo in the webchannel-wrapper's package.json. #8331
Conversation
🦋 Changeset detectedLatest commit: 082337f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅
|
Size Report 1Affected ProductsNo changes between base commit (ca41391) and merge commit (fb03103).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (ca41391) and merge commit (fb03103).Test Logs |
|
Done. |
| "@firebase/webchannel-wrapper": patch | ||
| --- | ||
|
|
||
| fix: Fix a typo in the webchannel-wrapper's package.json that affected ems5 exports. |
There was a problem hiding this comment.
drive-by comment: there is a typo in the release notes: "ems5" should be "esm5". That is proving to be a difficult acronym to spell correctly.
There was a problem hiding this comment.
ouch :(
It seems that this doesn't show up on the release notes (https://firebase.google.com/support/release-notes/js) page though (because it's a webchannel-wrapper package change?)
There was a problem hiding this comment.
Hmm not sure about webchannel-wrapper release notes showing up. Maybe they're not included, but, rather, expect to be mentioned by the dependents upgrading their dependency (i.e. a Firestore change that has its own release note that goes with the webchanne-wrapper upgrade).
There was a problem hiding this comment.
Hi, I wrote the release notes for the 10.12.3 release where this went out. I mistakingly excluded this from the release notes. Looking at older release notes, we list changes to webchannel-wrapper under Firestore.
Sorry if I caused any confusion- I'll create a CL to mention this change in the release notes.
There was a problem hiding this comment.
We can fix the typo in your CL then. Thanks @dlarocque.
There was a problem hiding this comment.
Please add me as reviewer for your CL. Thanks :)
There was a problem hiding this comment.
Please add me as reviewer for your CL. Thanks :)
Sounds good. I added you as a reviewer
* fix: Fix a typo in the webchannel-wrapper's package.json. * Create orange-rings-own.md
Fixes a typo in the webchannel-wrapper's package.json that affected ems5 exports.