Make reset #17
Make reset #17
Conversation
|
@JeronimoC23 Probando me paso que si no existe la imagen el comando explota. Lo que deberia pasar es que el comando siga normal y haga el docker-compose up no? 🤔 |
|
@JeronimoC23 fijate que la historia de la branch arranco mal y todavia tiene los commits viejos que elimine |
|
@JeronimoC23 Podremos validar que exista el archivo que vamos a subir? recien probe y funco todo pero yo no tenia el config.ini |
Makefile
Outdated
| current_dir = $(notdir $(shell pwd)) | ||
| addres_to_copy_the_lan_config = $(addprefix $(current_dir),_omeka_1:/var/www/html/application/config/config.ini) |
There was a problem hiding this comment.
se me ocurrio agregar unas variables mas para que se mas facil de entender y de cambiar si en un futuro cambia algo, como el nombre de la docker image por ejemplo
| current_dir = $(notdir $(shell pwd)) | |
| addres_to_copy_the_lan_config = $(addprefix $(current_dir),_omeka_1:/var/www/html/application/config/config.ini) | |
| docker_image_name = omeka | |
| current_dir = $(notdir $(shell pwd)) | |
| container_name := $(current_dir)_$(docker_image_name)_1 | |
| container_path_to_copy_config_file = $(addprefix $(container_name),:/var/www/html/application/config/config.ini) |
Makefile
Outdated
| @docker-compose stop | ||
|
|
||
| copy-config: | ||
| @docker cp ./config.ini $(addres_to_copy_the_lan_config) |
There was a problem hiding this comment.
si cambias lo del comment que te deje antes no te olvides de cambiar el nombre aca 👀
Makefile
Outdated
| copy-config: | ||
| @docker cp ./config.ini $(addres_to_copy_the_lan_config) | ||
|
|
||
| reset: down delete-image up copy-config stop up |
There was a problem hiding this comment.
podria llamarse rebuild-docker-image? o algo asi?
MJoaaquin
force-pushed
the
make-reset
branch
from
fbb12cd
to
768a18f
Compare
MJoaaquin
force-pushed
the
make-reset
branch
from
d79a2df
to
ec785a6
Compare
Creating and updating the Make file with some necessary docker and docker-compose commands