Heatindex #65
Heatindex #65
Conversation
1. remove the array for fahrenheit 2. store the coefficents into flash 3. intenially skipped, wrote textual reminder and add better return value handling 4. fixed fixed pull request finitespace#64 from finitespace by removing the code snippet fixed wrong usage of += include Math.h for round function
|
Why did you change Nan to -1? I would prefer Nan. |
|
@jirkaptr does this satisfy? |
|
I have merged HappyWheels fix for the semi-colon in the interim while we figure this out. Please make sure your code compiles before submitting a pull request. |
1. remove the array for fahrenheit 2. store the coefficents into flash 3. intenially skipped, wrote textual reminder and add better return value handling 4. fixed fixed pull request finitespace#64 from finitespace by removing the code snippet fixed wrong usage of += include Math.h for round function
1. remove the array for fahrenheit 2. store the coefficents into flash 3. intenially skipped, wrote textual reminder and add better return value handling 4. fixed fixed pull request finitespace#64 from finitespace by removing the code snippet fixed wrong usage of += include Math.h for round function
1. remove the array for fahrenheit 2. store the coefficents into flash 3. intenially skipped, wrote textual reminder and add better return value handling 4. fixed fixed pull request finitespace#64 from finitespace by removing the code snippet fixed wrong usage of += include Math.h for round function
…atindex heatindex changed to NWS formula. Use of #define for coeff
|
This pull request needs to be re-done. I can't tell what it going on. It also appears you are overriding some of the changes I made after merging your last code. |
…ation to reconstruct our thoughts.
|
@finitespace @jirkaptr #77 any annotations? |
|
My brief observations and remarks: - Readme.md regarding HeatIndex: - EnvironmentCalculations.cpp regarding HeatIndex(): @finitespace & @coelner, I think it's time to finish #65 and #77 and go to other matters. Sorry for edition of the text caused by my inattentive reading. |
#64 #63
for enhancing the formula see here: https://en.wikipedia.org/wiki/Heat_index
or this one: http:https://www.bom.gov.au/info/thermal_stress/#apparent
feel free to implement