Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed WebLLM Model Issues and UI Tweaks #157

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

fingerthief
Copy link
Owner

@fingerthief fingerthief commented Jun 14, 2024

Pull Request Summary

This pull request addresses issues with the WebLLM model integration and includes several UI improvements. Below is a summary of the changes:

  1. Bug Fixes:

    • WebLLM Model Integration: Updated the web-llm-api-access file to use the new messages object structure. This change ensures compatibility with WebLLM by distilling the messages object into a structure that WebLLM expects. [Commit 08477cb]
  2. UI Improvements:

    • Dialog Colors: Aligned dialog colors for a more consistent user experience. [Commit 8ef27d3]
    • Mobile UI Tweaks:
      • Moved the mobile model selector tag closer to the bottom of the screen for better accessibility.
      • Removed the database icon on the conversations dialog in mobile mode and slightly moved the context menu icon to the left.
      • Fixed some console errors related to interact mode. [Commit 2cfedd7]
  3. Version Update:

    • Updated the version information to reflect the new changes. [Commit 7ffba5e]

Commits:

  • 7ffba5e6545932798d7cb4f1f65f504ed0cde240: Update version info.
  • 08477cb5137a1ab23815c76fe1902a007075600d: Updated web-llm-api-access file to use the new messages object structure.
  • 8ef27d36079d99d4e49dcdad0082abda50edc2f1: Aligned dialog colors.
  • 2cfedd706c2e3412e3829ca4706f502b9c50fe66: Small UI tweaks and fixed console errors.

Impact:
These changes improve the integration with WebLLM by ensuring compatibility with the new messages object structure. The UI tweaks enhance the user experience by providing a more consistent and accessible interface, especially in mobile mode. The version update ensures that these improvements are properly documented and tracked.

Closes #156

Auto Generated Notes (Do Not Change)


Contents (#157)

Uncategorised!

  • Updated web-llm-api-access file to use the new messages object structure.
  • Update version info

…ure.

This was updated recently to enable vision request to maintain context in the conversation. But it appears that isn't a feature yet in WebLLM so this will distill the messages object into a structure WebLLM expects.
@fingerthief fingerthief added the bug Something isn't working label Jun 14, 2024
@fingerthief fingerthief added this to the 6.2.3 milestone Jun 14, 2024
@fingerthief fingerthief self-assigned this Jun 14, 2024
Copy link

Visit the preview URL for this PR (updated for commit 7ffba5e):

https://minimalgpt--pr157-bug-fixed-webllm-mod-gix4ygig.web.app

(expires Fri, 21 Jun 2024 22:39:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95b9f8da4861f0258375bb9789bfa436b4ed7d98

@fingerthief fingerthief merged commit 005eeee into main Jun 14, 2024
6 checks passed
@fingerthief fingerthief deleted the bug/fixed-webllm-model-issues branch June 14, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] WebLLM Models Are Not Functional Currently
1 participant