Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoredFiles Component Improvements and Bugfixes #146

Merged
merged 7 commits into from
Jun 8, 2024

Conversation

fingerthief
Copy link
Owner

@fingerthief fingerthief commented Jun 8, 2024

Pull Request Summary

This pull request includes a series of commits aimed at enhancing the overall functionality and user experience of the application. Below is a summary of the changes:

  1. New Features:

    • DialogHeader Component: Introduced a new DialogHeader component to ensure consistent headers across the application.
    • File Upload Enhancements: Improved the stored files dialog/component by integrating PrimeVue data-table, adding icons for deleting files and adding files to the current conversation context. The mobile layout has also been improved, and users can now upload files directly via the component. Additionally, logic has been added to automatically initialize the userFiles database if it doesn't exist, fixing bugs related to uploading the first file.
  2. Bug Fixes:

    • Token Count Issue: Fixed the issue where the token count was showing incorrect numbers due to the new messages object structure.
    • Duplicate Functions: Resolved the issue with duplicate addMessage functions that had different logic.
    • Scrolling Issue: Fixed a UX issue where users could not scroll the messages list if hovered over the padded left and right sides of the list.
  3. Code Improvements:

    • Folder Restructuring: Restructured the components folder to have area-specific folders for controls, dialogs, etc.
    • Removed Global Click Event Handler: Removed the global click event handler to improve performance and maintainability.
    • Icon Alignment: Improved the alignment and spacing of the top left icons.
  4. Version Update:

    • Updated the application version to reflect the new changes.

Impact:
These changes collectively improve the user experience, fix critical bugs, and enhance the maintainability and performance of the application.

Auto Generated Notes (Do Not Change)


Contents (#146)

Uncategorised!

  • Remove global click event handler
  • Improved the stored files dialog/component.
  • Fixed token count showing incorrect numbers caused by the new messages object structure.
  • Fixed a UX issue where users could not scroll the messages list if hovered over the padded left and right sides of the list.
  • Fixed issue with duplicate addMessage functions with different logic.
  • Update version
  • Created new DialogHeader component to have consistent headers across the app.

Added PrimeVue data-table for cleanliness with icons for deleting files and adding a file to the current conversation context.

Improved mobile layout

Added abiltiy to upload files directly via the component.

Added logic to automatically initalize the userFiles database if one doesn't exist.This fixes some bugs with uploading the first file.
…s object structure.

align and space the top left icons better.
…vered over the padded left and right sides of the list.
Actually fixed the token count issue so it parses the messages array properly.
…the app.

restructure components folder to have area specific folders for controls, dialogs etc..
@fingerthief fingerthief added bug Something isn't working enhancement New feature or request Usability Issue with the usability of the application labels Jun 8, 2024
@fingerthief fingerthief added this to the 6.2.2 milestone Jun 8, 2024
@fingerthief fingerthief self-assigned this Jun 8, 2024
Copy link

github-actions bot commented Jun 8, 2024

Visit the preview URL for this PR (updated for commit b61bc53):

https://minimalgpt--pr146-enhancment-general-i-tytu1oyw.web.app

(expires Sat, 15 Jun 2024 01:23:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95b9f8da4861f0258375bb9789bfa436b4ed7d98

@fingerthief fingerthief merged commit a471ef7 into main Jun 8, 2024
6 checks passed
@fingerthief fingerthief deleted the enhancment/general-improvements-and-bugfixes branch June 8, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Usability Issue with the usability of the application
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant