Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Audio Queueing and Modularize InteractMode Component #141

Merged

Conversation

o-stahl
Copy link
Collaborator

@o-stahl o-stahl commented Jun 2, 2024

Summary


This pull request introduces enhancements to the InteractMode component by modularizing it and creating a new audio-utils.js utility file. It also implements an audio queueing mechanism to prevent overlapping TTS tracks from playing over each other. This change sets the foundation for future enhancements like stopping and skipping audio tracks.

Key Changes


  1. Modularized InteractMode Component:
    • Separated the logic of the InteractMode component into a more modular structure.
  2. Created Audio Utils:
    • Added audio-utils.js to handle audio-related functionalities.
  3. Implemented Audio Queueing:
    • Added an audio queue to manage TTS playback and prevent overlapping audio.
  4. New State Variables:
    • Introduced audioQueue and audioIsPlaying state variables to manage the audio queue and playback state.

Benefits


  • Prevents overlapping TTS tracks, enhancing user experience.
  • Provides a more modular and maintainable codebase.
  • Lays the groundwork for future features like stopping and skipping audio tracks.

Auto Generated Notes (Do Not Change)


@fingerthief fingerthief self-requested a review June 2, 2024 13:40
@fingerthief fingerthief self-assigned this Jun 2, 2024
@fingerthief fingerthief added the enhancement New feature or request label Jun 2, 2024
@fingerthief fingerthief added this to the 6.2.2 milestone Jun 2, 2024
@fingerthief
Copy link
Owner

Pulled down the changes locally and did some testing, everything seems to be working smooth as butter!

Hopefully now that you're a collaborator, if you make the next branch directly off the main repo I think the workflows should run successfully and auto deploy the PR test site etc.. Hopefully

@fingerthief fingerthief merged commit e92782e into fingerthief:main Jun 2, 2024
2 of 3 checks passed
@o-stahl o-stahl deleted the feature/audio-queue-enhancements branch June 2, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants