Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance SettingsDialog: Code Organization, Import/Export, and Layout Updates #127

Merged
merged 9 commits into from
May 24, 2024

Conversation

fingerthief
Copy link
Owner

@fingerthief fingerthief commented May 24, 2024

Summary


This PR enhances the SettingsDialog functionality and improves overall code structure and maintainability.

Changes


  1. Code Structure:

    • Moved the bulk of the processing logic for the SettingsDialog into the settings-utils library.
    • Fixed bug causing copying message text by clicking the message label to fail.
  2. Settings Import/Export:

    • Updated the import/export logic to include saved custom configurations and system prompts.
  3. Layout Adjustments:

    • Adjusted the SettingsDialog layout:
      • Desktop: Maximum of 2 columns (config options).
      • Mobile: 1 column for a consistent and clean layout across all screen sizes.
    • Added various small animations to the application to ease some of the jarring transitions (WIP).
    • Default the SettingsDialog to open and take up exactly half of the viewport width.
  4. Color Theme:

    • Made slight color adjustments to the side panel and settings dialog to achieve a more cohesive theme.

Benefits


  • Improved code maintainability and structure.
  • Enhanced user experience with a consistent layout across devices.
  • More comprehensive settings import/export functionality.
  • Application transitions updates (WIP)

Auto Generated Notes (Do Not Change)


Contents (#127)

Other

  • Moved functions/logic from the SettingsDialog component into the settings-utils lib for cleaner code.

Uncategorised!

  • Moved custom api config logic into settings-utils library
  • Added CustomConfigs and SystemPrompts to the watchers to be updated correctly when values change.
  • Removed unnecessary watchers for customConfigs and systemPrompts as that is handled elsewhere
  • Updated pull request template
  • Fixed copyText bug causing copying to fail
  • Added animation for the conversations list and fixed issue where user input field wouldn't resize until after the message stream ended
  • Fix input field icons alignment
  • Adjusted the animations for opening/closing the settings dialog and conversations dialog

…he settings-utils lib for cleaner code.

Chore: Updated colors to be better aligned throughout the application.

Chore: Added system prompts and saved custom configs to the import/exporting settings logic.

Chore: Defaulting settings panel in desktop mode to 50vw
@fingerthief fingerthief added bug Something isn't working enhancement New feature or request labels May 24, 2024
@fingerthief fingerthief added this to the 6.1.5 milestone May 24, 2024
@fingerthief fingerthief self-assigned this May 24, 2024
Copy link

github-actions bot commented May 24, 2024

Visit the preview URL for this PR (updated for commit d524b7a):

https://minimalgpt--pr127-dev-general-improvem-9oybrfg1.web.app

(expires Fri, 31 May 2024 17:30:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95b9f8da4861f0258375bb9789bfa436b4ed7d98

@fingerthief fingerthief merged commit 078dda0 into main May 24, 2024
6 checks passed
@fingerthief fingerthief deleted the dev/general-improvements branch May 24, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant