Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task#index #53

Merged
merged 12 commits into from
Apr 30, 2020
Merged

Task#index #53

merged 12 commits into from
Apr 30, 2020

Conversation

mollycalypso
Copy link
Collaborator

@mollycalypso mollycalypso commented Apr 27, 2020

Overview

Update:
Task Index Page
Fixed Navbar
Updated/Troubleshooted Navbar

Configuration

Need to change jquery version (current version doesn't work with the navbar bootstrap collapse)
yarn remove jquery

yarn add [email protected]

Details

✔️updated various views to ensure navbar doesn't cover page content
✔️updated Navbar CSS and JS to have two versions of Navbar colors depending on page background
✔️fixed the Navbar Collapse bootstrap for small screens with help from Daniel (jquery version)
✔️minor adjustments to Task Index Page
✔️🤯😭(MEME BELOW)fixed the nav-links to be in the middle of the screen for small screens
✔️🤯😭(MEME BELOW)fixed when you open the toggler on the small screen, then scroll up, the links disappear

@gabrielecanepa gabrielecanepa changed the title Alltasks index page Style tasks index Apr 28, 2020
@gabrielecanepa gabrielecanepa changed the title Style tasks index Task#index Apr 28, 2020
@todo
Copy link

todo bot commented Apr 29, 2020

remove after implementing pundit %>

https://github.com/localhelp/findlocal.help/blob/4c55db1e75ce21839e258fd64edf68b1dfd3bdc3/app/views/tasks/edit.html.erb#L5-L10


This comment was generated by todo based on a TODO comment in 4c55db1 in #53. cc @localhelp.

@todo
Copy link

todo bot commented Apr 29, 2020

remove after implementing pundit %>

https://github.com/localhelp/findlocal.help/blob/2b8ba0484c23523c80b87e26bca4b0622ae80494/app/views/tasks/edit.html.erb#L5-L10


This comment was generated by todo based on a TODO comment in 2b8ba04 in #53. cc @localhelp.

@todo
Copy link

todo bot commented Apr 29, 2020

remove after implementing pundit %>

https://github.com/localhelp/findlocal.help/blob/31d855a4bbc20d69b2b5e0b93bddedec1ba6e9a6/app/views/tasks/edit.html.erb#L5-L10


This comment was generated by todo based on a TODO comment in 31d855a in #53. cc @localhelp.

@todo
Copy link

todo bot commented Apr 29, 2020

remove after implementing pundit %>

https://github.com/localhelp/findlocal.help/blob/ebb93ffc93f0ac3da295779d06221a82b6852412/app/views/tasks/edit.html.erb#L5-L10


This comment was generated by todo based on a TODO comment in ebb93ff in #53. cc @localhelp.

Copy link
Contributor

@gabrielecanepa gabrielecanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't be doing reviews here anymore @localhelp/developers. If you need me during the day just open a ticket on kitt ;)

@todo
Copy link

todo bot commented Apr 30, 2020

remove after implementing pundit %>

https://github.com/localhelp/findlocal.help/blob/1f9f6cc7da632df33d57be5f57afeb53a2a364b2/app/views/tasks/edit.html.erb#L5-L10


This comment was generated by todo based on a TODO comment in 1f9f6cc in #53. cc @localhelp.

@todo
Copy link

todo bot commented Apr 30, 2020

remove after implementing pundit %>

https://github.com/localhelp/findlocal.help/blob/36ade7408fd94d2b2f968f7281bf3694c7cad7d9/app/views/tasks/edit.html.erb#L5-L10


This comment was generated by todo based on a TODO comment in 36ade74 in #53. cc @localhelp.

@todo
Copy link

todo bot commented Apr 30, 2020

remove after implementing pundit %>

https://github.com/localhelp/findlocal.help/blob/13d0b222eae54650d984a5341d602e951c19c24b/app/views/tasks/edit.html.erb#L5-L10


This comment was generated by todo based on a TODO comment in 13d0b22 in #53. cc @localhelp.

@jones-sam jones-sam merged commit 4f8f75c into master Apr 30, 2020
@jones-sam jones-sam deleted the alltasks_index_page branch April 30, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants