-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task#index #53
Merged
Merged
Task#index #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielecanepa
force-pushed
the
alltasks_index_page
branch
from
April 28, 2020 13:10
d3e71d6
to
581a84d
Compare
jones-sam
force-pushed
the
alltasks_index_page
branch
from
April 29, 2020 14:05
581a84d
to
4c55db1
Compare
remove after implementing pundit %>This comment was generated by todo based on a
|
remove after implementing pundit %>This comment was generated by todo based on a
|
remove after implementing pundit %>This comment was generated by todo based on a
|
mollycalypso
force-pushed
the
alltasks_index_page
branch
from
April 29, 2020 18:05
31d855a
to
ebb93ff
Compare
remove after implementing pundit %>This comment was generated by todo based on a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't be doing reviews here anymore @localhelp/developers. If you need me during the day just open a ticket on kitt ;)
…ndlocal.help into alltasks_index_page
remove after implementing pundit %>This comment was generated by todo based on a
|
remove after implementing pundit %>This comment was generated by todo based on a
|
remove after implementing pundit %>This comment was generated by todo based on a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update:
Task Index Page
Fixed Navbar
Updated/Troubleshooted Navbar
Configuration
Need to change jquery version (current version doesn't work with the navbar bootstrap collapse)
yarn remove jquery
yarn add [email protected]
Details
✔️updated various views to ensure navbar doesn't cover page content
✔️updated Navbar CSS and JS to have two versions of Navbar colors depending on page background
✔️fixed the Navbar Collapse bootstrap for small screens with help from Daniel (jquery version)
✔️minor adjustments to Task Index Page
✔️🤯😭(MEME BELOW)fixed the nav-links to be in the middle of the screen for small screens
✔️🤯😭(MEME BELOW)fixed when you open the toggler on the small screen, then scroll up, the links disappear