Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(setup.py/constants.py/test_all.py): Add Vietnamese #42

Merged
merged 4 commits into from
Nov 22, 2021

Conversation

khiemledev
Copy link
Contributor

Hello @filyp, I'm interested in this work. I want to contribute my language to your repo, please tell me if there's any issue.

@filyp
Copy link
Owner

filyp commented Nov 17, 2021

All looks good :)
I also need the tar.gz file you created. You can either upload it to IPFS yourself (for example with Pinata, which will pin this file so it doesn't disappear) and add the path to ipfs_paths, or share it with me however you like and I will upload it.

@khiemledev
Copy link
Contributor Author

Hi @filyp, I did it!
Now you can merge the code into the main branch :)

@filyp
Copy link
Owner

filyp commented Nov 20, 2021

The last two things:

  • delete word_count.json from repo as it's not needed
  • fix the code style with black (the tests are failing because of that)

@filyp
Copy link
Owner

filyp commented Nov 22, 2021

Great, everything passes now. Vietnamese has quite low correction quality (bad: 53/64) but I assume that's because Vietnamese is just hard to autocorrect. So I'll merge.

Thanks for contributing!

@filyp filyp merged commit 3ad49ac into filyp:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants