Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Greek Language #27

Closed
wants to merge 6 commits into from
Closed

Add support for Greek Language #27

wants to merge 6 commits into from

Conversation

magdalini-anastasiadou
Copy link
Contributor

Hi,
I've made a few changes:

  • generated and edit a Greek vocab dictionary (el.tar.gz)
  • updated constants.py to support the Greek alphabet
  • added a short test to the test_all.py

@filyp
Copy link
Owner

filyp commented Apr 3, 2021

Awesome! I'll check it and merge next week. I only don't want to add tar files to the repo, because it would bloat too much, so you can either make a new PR without it, or I can cherrypick the rest of the files.

@magdalini-anastasiadou
Copy link
Contributor Author

Okay, I have deleted the file and change it with a url in constants.py

@filyp
Copy link
Owner

filyp commented Apr 6, 2021

I'm afraid that this file is still in git history, so it's still bloating the repo. Could you delete it from history too? Or make a fresh PR without this file, with all the rest of the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants