Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jmh,query): Fix PlanDispatcher timeout handling + QueryInMemoryBenchmark #783

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

velvia
Copy link
Member

@velvia velvia commented Jun 10, 2020

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)

  • If a query times out in PlanDispatcher check, an error is thrown which is not handled in standard Query flow, causing QueryActor to be restarted sometimes
  • QueryInMemoryBenchmark was timing out due to old query IDs, and spread not being correct

New behavior :

  • PlanDispatcher now returns a QueryError properly
  • QueryInMemoryBenchmark queries now all have unique startTime, and spread is fixed. Benchmark now runs to completion

@velvia velvia merged commit 6838120 into filodb:develop Jun 10, 2020
@velvia velvia deleted the spread-all-perf-debug branch June 10, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants