Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sparkJobs): If tracing downsampler, log chunks read from cassandra #757

Merged
merged 1 commit into from
May 22, 2020
Merged

feat(sparkJobs): If tracing downsampler, log chunks read from cassandra #757

merged 1 commit into from
May 22, 2020

Conversation

vishramachandran
Copy link
Member

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

@vishramachandran vishramachandran self-assigned this May 21, 2020
@whizkido whizkido requested review from whizkido and removed request for whizkido May 21, 2020 23:55
whizkido
whizkido approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@whizkido whizkido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishramachandran vishramachandran merged commit aaa3931 into filodb:develop May 22, 2020
@vishramachandran vishramachandran deleted the trace-chunks-downsample branch May 22, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whizkido whizkido whizkido approved these changes

@tjackpaul tjackpaul Awaiting requested review from tjackpaul

Assignees

@vishramachandran vishramachandran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishramachandran @whizkido