Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(query): Utility to convert ColumnFilters in LogicalPlan #751

Merged
merged 7 commits into from
May 21, 2020

Conversation

tjackpaul
Copy link
Member

@tjackpaul tjackpaul commented May 20, 2020

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Need to convert the LogicalPlan ColumnFilters to a plain java object. It is required to blacklist queries. And the operator is required to handle the user metric/label sharing policies.

Deleted the duplicate LogicalPlanUtil in Query module and moved that to LogicalPlanUtils in coordinator module itself.

Copy link
Contributor

@TanviBhavsar TanviBhavsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@velvia velvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for the most part.... I think it belongs better in query module not coordinator (ie it should live next to LogicalPlan itself -- or instead of Utils just put it in the LogicalPlan object)

@tjackpaul
Copy link
Member Author

Looks fine for the most part.... I think it belongs better in query module not coordinator (ie it should live next to LogicalPlan itself -- or instead of Utils just put it in the LogicalPlan object)

Unfortunately we can't move due to the dependency hierarchy. Few of the classes that it depends on belongs to coordinator module only and query does not depend upon coordinator, it is the other way.

@tjackpaul tjackpaul merged commit 977187d into filodb:develop May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants