Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocreate / autodelete #4

Closed
wants to merge 8 commits into from
Closed

Add autocreate / autodelete #4

wants to merge 8 commits into from

Conversation

jhlee-mitre
Copy link
Contributor

Added autocreate and autodelete

Change summary:

  • general_test_script.json -> set autocreate and autodelete -> true for testing
  • Added autocreate under 'load_fixture'. Need to discuss where the code be placed.
  • In case of autocreate = true and create exists in setup section in TS, give warning.
  • Added autodelete under 'postprocess'.Need to discuss whether we need a separate method for post processing.

ms-k1ngk0ng
ms-k1ngk0ng reviewed Jun 1, 2022
View reviewed changes
Copy link
Contributor

@ms-k1ngk0ng ms-k1ngk0ng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was accidentally built on top of the score PR. Will work with @jhlee-mitre to figure out where in the git history we can cherry-pick out the relevant changes.

@jhlee-mitre jhlee-mitre closed this Jun 1, 2022
@jhlee-mitre jhlee-mitre deleted the add_autocreate branch June 1, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms-k1ngk0ng ms-k1ngk0ng ms-k1ngk0ng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhlee-mitre @ms-k1ngk0ng