Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for History operation #1

Merged
merged 7 commits into from
May 13, 2022
Merged

Conversation

jhlee-mitre
Copy link
Contributor

Major changes:

  1. Added TestScripts and fixtures for Observation Resource
  2. Added TestScript and testing codes for history
  3. Updated read.me

Copy link
Contributor

@ms-k1ngk0ng ms-k1ngk0ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I would rename this PR to be more descriptive about what it's accomplishing. Something like 'Add support for History operation'.
  • We should hide the TestReports directory from git. I think it's excessive to push up every TestReport we create -- especially if running the engine will just recreate them anyways.
  • The opposite for TestScripts -- let's keep pushing up every new, unique TestScript we find/create.
  • We need to solidify on our naming conventions for both TestScripts and TestReports. I know that probably seems excessive and semantic at this point, but I think it's gonna help keep us organized in the long run. I'll start a Slack thread about it.
  • Last, we need to get back in the habit of writing unit tests. The ones we have are .... less than stellar. I'm going to get you started on some unit tests specifically for history and then push them up and let you take them over the finish line @jhlee-mitre. And then in the near future, you'll have the joy of rewriting our existing tests, which will help us cover our bases and confirm that what we have works well.

Thrilled to have you working on this and keep pushing it forward 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/TestScriptEngine.rb Show resolved Hide resolved
@jhlee-mitre jhlee-mitre changed the title Jaehoon feature experimental Add support for History operation May 12, 2022
jhlee-mitre and others added 3 commits May 12, 2022 16:41
Co-authored-by: Jack Fraser <[email protected]>
Co-authored-by: Jack Fraser <[email protected]>
Co-authored-by: Jack Fraser <[email protected]>
@jhlee-mitre
Copy link
Contributor Author

Accepted Jack's suggestions. Read.me content has rooms for improvement.

@jhlee-mitre jhlee-mitre merged commit 3cbd8b8 into main May 13, 2022
@jhlee-mitre jhlee-mitre deleted the jaehoon_feature_experimental branch May 13, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants