This repository has been archived by the owner on Jan 2, 2022. It is now read-only.
Retrieval of data types in ARGetMultipleFields() #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dataType' argument instead of the 'limit' argument. This fixes (for me) issue with AR_DATA_TYPE_TIME fields type getting incorrect type AR_DATA_TYPE_NULL.
Also, string values are encoded as utf-8 when input and decoded from utf-8 when output. Maybe, this should be optional.
|
Appreciate your efforts on this, but there's way too much going on with this pull request. I see Python 3 compatibility added and so on. I cannot accept the pull request in the current form. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to use the 'dataType' argument instead of the 'limit' argument.
This fixes (for me) issue with AR_DATA_TYPE_TIME fields type getting incorrect type AR_DATA_TYPE_NULL.